Conversation
…ct() before session id - Render empty #blackbox-challenge-root on login when blackbox-login is enabled - Pass challengeContainer via data-challenge-container on the Blackbox script tag - Call Blackbox.collect() before getSessionId() on password login submit - Extend Window types and add jsdom unit tests for ordering and edge cases Made-with: Cursor
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
matticbot
added
[Status] Needs Review
dbecher
reviewed
Apr 1, 2026
| } | ||
|
|
||
| try { | ||
| await runBlackboxCollect(); |
There was a problem hiding this comment.
I think you can just change window.Blackbox.getSessionId() below to window.Blackbox.collect(), and then return result.sessionId.
I suppose we're not actually checking the result for a challenge here and blocking the login submission yet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made-with: Cursor