Migrate comment email subscription hooks to api-core/api-queries#109800
Draft
gabrielcaires wants to merge 1 commit intotrunkfrom
Draft
Migrate comment email subscription hooks to api-core/api-queries#109800gabrielcaires wants to merge 1 commit intotrunkfrom
gabrielcaires wants to merge 1 commit intotrunkfrom
Conversation
…D-408) Extract pure mutator functions (updateSiteCommentEmailSubscription, deletePostCommentEmailSubscription) into @automattic/api-core and create mutationOptions wrappers in @automattic/api-queries. Update data-stores hooks to use the new api-core mutators instead of the custom callApi helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of READ-408
Proposed Changes
updateSiteCommentEmailSubscription,deletePostCommentEmailSubscription) into@automattic/api-coreunderread-comment-email-subscriptions/.mutationOptions()wrappers (siteEmailMeNewCommentsMutation,postCommentEmailUnsubscribeMutation) in@automattic/api-queries.data-storeshooks (useSiteEmailMeNewCommentsMutation,usePostUnsubscribeMutation) to use the new api-core mutators instead of the customcallApi()helper, while preserving existing optimistic update logic.Why are these changes being made?
This is part of an ongoing migration (Phase 3) to move Reader query/mutation logic from
data-storesto the standardizedapi-core/api-queriespattern. Centralizing API calls inapi-corewithwpcom-fetcherand exposingmutationOptionsfromapi-queriesimproves reusability, testability, and consistency across clients.Testing Instructions
Pre-merge Checklist