Site Launch: ship semi-gated flow as default after gating experiment#111638
Draft
bogiii wants to merge 1 commit into
Draft
Site Launch: ship semi-gated flow as default after gating experiment#111638bogiii wants to merge 1 commit into
bogiii wants to merge 1 commit into
Conversation
The calypso_standardized_site_launch_gating_202603_v1 experiment concluded with semi_gated_site_launch as the winning variant. Replace the per-call-site useExperiment() calls with a shared useSiteLaunchGatingVariant() hook that hardcodes the semi-gated variant, keeping all existing variant branches as scaffolding so the expected follow-up experiment only needs a one-line change in the hook. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
calypso_standardized_site_launch_gating_202603_v1experiment by shipping thesemi_gated_site_launchvariant as the default behavior for everyone.useSiteLaunchGatingVariant()hook (client/lib/explat/site-launch-gating.ts) that currently hardcodes the semi-gated variant. It lives undercalypso/lib/explat/so the Dashboard's existing ESLint import exception covers it.useExperiment()calls with the shared hook in:client/layout/masterbar/masterbar-launch-button.tsxclient/hosting/performance/site-performance.tsxclient/dashboard/sites/site-launch-button/use-site-launch.tsxclient/my-sites/customer-home/cards/launchpad/pre-launch.tsxuseExperiment) so the ungated scaffolding path remains tested.Why are these changes being made?
/start/launch-site) as the default.useExperiment()call in a single file, with every launch surface (masterbar, performance page, dashboard launch button, launchpad) enrolled automatically.useExperiment()for a finished experiment would keep firing useless assignment requests; the hardcoded hook avoids that.Testing Instructions
/start/launch-site(semi-gated flow) instead of launching directly./start/launch-siteflow.yarn typecheck-client,yarn eslinton the touched files, andyarn test-client client/dashboard/app/interim-omnibar/test/omnibar-launch-button.test.tsxall pass.Pre-merge Checklist