Reader: fix wide unread count badges overflowing sidebar column#111662
Open
le-sgs wants to merge 1 commit into
Open
Reader: fix wide unread count badges overflowing sidebar column#111662le-sgs wants to merge 1 commit into
le-sgs wants to merge 1 commit into
Conversation
The unread-count badge column on Reader sidebar organization items was fixed at 36px, which caused wider compact values like "4.9K" to overflow and visually break list alignment against shorter values. Widen the column to 48px, right-align badges within the column so all counts share a consistent right edge regardless of width, and add `white-space: nowrap` on the badge to keep its content on one line. Attempts to fix READ-535 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
client/reader/sidebar/style.scss, widen the unread-count grid column from36pxto48px, right-align badges within the column (justify-self: endreplacingmargin: 0 auto), and addwhite-space: nowrapon.a8c-count.Why are these changes being made?
The unread-count badge column on Reader sidebar organization items was a fixed
36px. Compact-formatted values like4.923 miare wider than 1–3 digit values, so they overflowed the column, got pushed flushagainst the right edge of the container, and broke the visual alignment of the list against shorter counts like
989,977,613.Widening the column gives compact-K values room to render, right-aligning all badges keeps the column visually consistent regardless of badge width, and
white-space: nowrapis defensive so the text neverwraps inside the badge.
Testing Instructions
/readerwhile signed in to an account.Before / After
Before:
4.923 milbadge pushed flush against the panel border, visually misaligned with shorter counts in the same column.After:
4.923 miland shorter counts both right-align in a wider column with comfortable spacing.Pre-merge Checklist