Site Overview: Add accessible name to unlaunched site setup progress ring - #113338
Merged
Conversation
|
WordPress.com
Automattic for Agencies
|
p-jackson
marked this pull request as ready for review
August 6, 2026 09:25
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/34678102 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @p-jackson, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOTMSD-1475
Proposed Changes
ariaLabelprop to the sharedCircularProgressBarcomponent and wire therole="progressbar"element witharia-valuemin/aria-valuemax/aria-valuenow/aria-label.ariaLabel="Steps to launch your site"from the Site OverviewOverviewCardunlaunched-site setup progress ring.Why are these changes being made?
The
1/4visibility progress ring on Site Overview announced nothing to assistive tech — axe flaggedaria-progressbar-name. Therole="progressbar"element had no accessible name and no value semantics, so screen readers couldn't convey what it represented or how far along it was. This gives it a name and exposes its min/max/current values.Testing Instructions
.circular__progress-bar) and confirm it now hasaria-label="Steps to launch your site"plusaria-valuemin/aria-valuemax/aria-valuenow.aria-progressbar-nameviolation is gone and the ring announces its label and progress.Pre-merge Checklist