[Odie][PoC][DRAFT] Standalone Odie client #84069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~613 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~5335 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4937 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Comment on lines
+6
to
+14
| function omit( obj, fields ) { | ||
| const newObj = { ...obj }; | ||
| for ( const field of fields ) { | ||
| if ( newObj.hasOwnProperty( field ) ) { | ||
| delete newObj[ field ]; | ||
| } | ||
| } | ||
| return newObj; | ||
| } |
There was a problem hiding this comment.
This is the result of removing lodash library. It was included as a dependency in order to load it's omit function
Comment on lines
+66
to
+74
| const { isMinimized } = useSelect( ( select ) => { | ||
| const store = select( HELP_CENTER_STORE ) as HelpCenterSelect; | ||
| return { | ||
| show: store.isHelpCenterShown(), | ||
| isMinimized: store.getIsMinimized(), | ||
| initialRoute: store.getInitialRoute(), | ||
| }; | ||
| }, [] ); | ||
|
|
There was a problem hiding this comment.
Removed the Help Center dependency
Comment on lines
10
to
12
| import MinimizeIcon from 'calypso/assets/images/odie/minimize-icon.svg'; | ||
| import WapuuAvatar from 'calypso/assets/images/odie/wapuu-squared-avatar.svg'; | ||
| import WapuuThinking from 'calypso/assets/images/odie/wapuu-thinking.svg'; |
There was a problem hiding this comment.
These assets should be moved inside the package
Comment on lines
13
to
14
| import Gravatar from 'calypso/components/gravatar'; | ||
| import { getCurrentUser } from 'calypso/state/current-user/selectors'; |
There was a problem hiding this comment.
We need to inject this as a component to represent the user's profile. It ca be a new prop for Odie,
<OdieProvider
...
...
userAvatarComponent={<Gravatar... />}
>
{ children }
<OdieProvider/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is just a draft where I am trying to create a new package so we can use this client that already connects with our
ai-services.We still need to remove two dependencies (and probably delete the code, I think we don't need it as I did it thinking around Jetpack). That code lives on
odie/query/index.tsLastly, we should inject the User's avatar or display image. Right now its a Calypso dependency using Gravatar component.
Addressing those two things, we have almost decoupled the client from Calypso, and next steps would be to generate a package and add it as a dependency to Calypso or whatever.
All the files in the
utilsfolder are added as a copy from elsewhere in calypso.DISCLAIMER
Please bear in mind that the current Odie client code is going to be live and actively used next Monday, do not merge if we are not fully sure that the changes we are doing are working.
Testing Instructions
Pre-merge Checklist