Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced sites fallback #92426

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Remove forced sites fallback #92426

wants to merge 1 commit into from

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jul 5, 2024

Related to # https://github.com/Automattic/dotcom-forge/issues/8070

Proposed Changes

  • Removes forced /sites fallback from sidebar links allowing the global sidebar to determine the back link location

Testing Instructions

  • Click around global nav ensure back links make sense

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-back on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~11 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                                -22 B  (-0.0%)      -11 B  (-0.0%)
jetpack-cloud-plugin-management        -22 B  (-0.0%)      -11 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl
Copy link
Contributor Author

lsl commented Jul 5, 2024

Pushed to share the offending code seam, doesn't actually fix the problem, see discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants