-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Fix has Pressable existing plan logic #98272
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~37 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Test 1: It works well for the typical scenario, an agency with a Pressable account, already connected to A4A. |
The fix requirements: These are the different states we have to handle:
*Note that maybe we could use the |
This PR resolves the logic for identifying the current Pressable plan. At present, users cannot upgrade through the UI if the current agency has existing Pressable account.
Proposed Changes
usePressableOwnershipType
hook logic so it checks for existing pressable plan with an existing account.Why are these changes being made?
Testing Instructions
/marketplace/hosting/pressable
page.Pre-merge Checklist