Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix header spacing on search screen #98496

Open
wants to merge 1 commit into
base: fix/reader-search-no-results-screen
Choose a base branch
from
Open

Reader: Fix header spacing on search screen #98496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/reader/search-stream/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ class SearchStream extends React.Component {
<div className="search-stream__fixed-area" ref={ this.handleFixedAreaMounted }>
<NavigationHeader
title={ translate( 'Search' ) }
style={ { width: this.props.width } }
subtitle={ translate( 'Search for specific topics, authors, or blogs.' ) }
/>
<CompactCard className="search-stream__input-card">
Expand Down
23 changes: 17 additions & 6 deletions client/reader/search-stream/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
@import "@wordpress/base-styles/variables";

.is-section-reader .search-stream__fixed-area {
// Main layout already has mx
.navigation-header {
margin: 0 auto;
padding: 16px 0 16px 0;
@include break-medium {
padding: 0;
}
}
}

Expand All @@ -31,7 +31,6 @@
max-width: 905px;
margin: 0 auto;
padding-inline: 24px;
padding-top: 0 !important;
}

.search-stream__intro {
Expand Down Expand Up @@ -95,16 +94,28 @@
}

.search-stream .search-stream__input-card.card {
margin-bottom: 0;
margin-inline: 16px;
border-radius: 4px;
@include breakpoint-deprecated( "<660px" ) {

@include break-small {
margin-inline: 0;
}

@include breakpoint-deprecated( "<660px" ) {
.search__icon-navigation {
border-radius: 4px;
}
}
}

.reader-blank-suggestions {
padding: 0 16px;

@include break-small {
padding: 0;
}
}

.search-stream__input-card.card {
margin-bottom: 16px;
padding: 0;
Expand Down
2 changes: 1 addition & 1 deletion client/reader/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ body.is-section-reader {
}

.is-group-reader {
@media screen and (min-width: 782px) {
@media screen and (min-width: $break-medium) {
.navigation-header::after {
content: "";
display: block;
Expand Down
Loading