Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Remove migration flow and specialized steps #98503

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Jan 16, 2025

Closes #98325

Proposed Changes

  • Remove /setup/migration flow and all specialized steps.

Why are these changes being made?

  • This flow was part of an A/B test that was discarded, so it is unavailable to the users.

Testing Instructions

  • Since it is just removing the files, visual inspection should be enough.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires marked this pull request as ready for review January 16, 2025 20:44
@gabrielcaires gabrielcaires requested a review from a team as a code owner January 16, 2025 20:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2025
@gabrielcaires gabrielcaires requested review from a team and removed request for a team January 16, 2025 20:44
@gabrielcaires gabrielcaires marked this pull request as draft January 16, 2025 20:49
@matticbot
Copy link
Contributor

matticbot commented Jan 16, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-migration-flow on your sandbox.

@gabrielcaires gabrielcaires marked this pull request as ready for review January 16, 2025 21:05
@gabrielcaires gabrielcaires requested a review from a team as a code owner January 16, 2025 21:05
@gabrielcaires gabrielcaires removed the request for review from a team January 16, 2025 21:05
@gabrielcaires
Copy link
Contributor Author

I added the DO_NOT_MERGE label because there are references to this flow on the wpcom repo fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Syvo%2Szvtengvba%2Szvtengvba%2Qsybj.cuc%3Se%3Qs543qn75%23193-og

@gabrielcaires gabrielcaires self-assigned this Jan 16, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 16, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~899 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              -6387 B  (-0.5%)     -736 B  (-0.2%)
entry-main                 -2575 B  (-0.1%)     -534 B  (-0.1%)
entry-subscriptions        -1495 B  (-0.1%)     -371 B  (-0.1%)
entry-login                -1495 B  (-0.1%)     -371 B  (-0.1%)
entry-domains-landing      -1495 B  (-0.2%)     -371 B  (-0.2%)
entry-browsehappy          -1495 B  (-0.7%)     -371 B  (-0.6%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~19730 bytes removed 📉 [gzipped])

name                               parsed_size             gzip_size
migration-flow                        -42054 B  (deleted)   -14285 B  (deleted)
import-hosted-site-flow                 -582 B    (-0.0%)     +841 B    (+0.2%)
site-migration-flow                     -579 B    (-1.0%)    -1394 B    (-7.5%)
hosted-site-migration-flow              -579 B    (-1.0%)    -1394 B    (-7.4%)
plans                                   -547 B    (-0.0%)     -420 B    (-0.1%)
staging-site                            -534 B    (-0.0%)      +47 B    (+0.0%)
write-flow                              -358 B    (-0.0%)      -41 B    (-0.0%)
update-design-flow                      -358 B    (-0.0%)     +154 B    (+0.0%)
transferring-hosted-site-flow           -358 B    (-0.1%)      -21 B    (-0.0%)
stepper-user-step                       -358 B    (-0.1%)      -23 B    (-0.0%)
plugin-bundle-flow                      -358 B    (-0.1%)      +21 B    (+0.0%)
newsletter-post-setup-flow              -358 B    (-0.1%)      -19 B    (-0.0%)
link-in-bio-tld-flow                    -358 B    (-0.0%)     +183 B    (+0.0%)
link-in-bio-post-setup-flow             -358 B    (-0.1%)      -19 B    (-0.0%)
entrepreneur-flow                       -358 B    (-0.2%)      -38 B    (-0.1%)
domain-user-transfer-flow               -358 B    (-0.1%)      -28 B    (-0.0%)
copy-site-flow                          -358 B    (-0.0%)      +60 B    (+0.0%)
build-flow                              -358 B    (-0.0%)      -41 B    (-0.0%)
hosting                                 -289 B    (-0.0%)    -1316 B    (-0.2%)
site-settings                           -245 B    (-0.0%)     +998 B    (+0.2%)
domains                                 -221 B    (-0.0%)     -146 B    (-0.0%)
checkout                                -204 B    (-0.0%)    -1048 B    (-0.2%)
people                                  +196 B    (+0.0%)     +800 B    (+0.3%)
site-tools                              -184 B    (-0.0%)     -598 B    (-0.1%)
sites-dashboard                         -171 B    (-0.0%)     -116 B    (-0.0%)
site-performance                        -171 B    (-0.0%)      -90 B    (-0.0%)
site-marketing                          -171 B    (-0.0%)      -88 B    (-0.0%)
settings                                +171 B    (+0.0%)     +782 B    (+0.2%)
hosting-features                        -171 B    (-0.0%)     -117 B    (-0.0%)
github-deployments                      -171 B    (-0.0%)      -31 B    (-0.0%)
site-monitoring                         -145 B    (-0.0%)     -256 B    (-0.1%)
site-logs                               -145 B    (-0.0%)     -108 B    (-0.0%)
site-setup-wg                           -143 B    (-0.0%)      -43 B    (-0.0%)
site-setup-flow                         -143 B    (-0.0%)      -43 B    (-0.0%)
site-overview                           +142 B    (+0.0%)     -175 B    (-0.0%)
site-purchases                           -85 B    (-0.0%)    -2432 B    (-0.4%)
purchases                                -85 B    (-0.0%)    -2432 B    (-0.3%)
plugins                                  -38 B    (-0.0%)     +161 B    (+0.0%)
themes                                   -25 B    (-0.0%)       -7 B    (-0.0%)
theme                                    -25 B    (-0.0%)       -7 B    (-0.0%)
site-blocks                              -25 B    (-0.0%)       -9 B    (-0.0%)
signup                                   -25 B    (-0.0%)       +5 B    (+0.0%)
security                                 -25 B    (-0.0%)       -9 B    (-0.0%)
privacy                                  -25 B    (-0.0%)       -9 B    (-0.0%)
notification-settings                    -25 B    (-0.0%)       -9 B    (-0.0%)
me                                       -25 B    (-0.0%)       -9 B    (-0.0%)
marketplace                              -25 B    (-0.0%)       -7 B    (-0.0%)
jetpack-connect                          -25 B    (-0.0%)      +80 B    (+0.0%)
jetpack-cloud-settings                   -25 B    (-0.0%)       -3 B    (-0.0%)
jetpack-cloud-pricing                    -25 B    (-0.0%)     +153 B    (+0.1%)
jetpack-cloud-features-comparison        -25 B    (-0.0%)      +82 B    (+0.0%)
jetpack-app                              -25 B    (-0.0%)     +133 B    (+0.1%)
home                                     -25 B    (-0.0%)     -204 B    (-0.0%)
help                                     -25 B    (-0.0%)       -9 B    (-0.0%)
email                                    -25 B    (-0.0%)       +3 B    (+0.0%)
developer                                -25 B    (-0.0%)       -9 B    (-0.0%)
account-close                            -25 B    (-0.0%)       -9 B    (-0.0%)
account                                  -25 B    (-0.0%)       -9 B    (-0.0%)
settings-jetpack                         +13 B    (+0.0%)      +30 B    (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-initial-intent                                                 -358 B  (-0.3%)      -38 B  (-0.1%)
async-load-automattic-onboarding-src-step-container                                    -358 B  (-1.2%)      -18 B  (-0.2%)
async-load-calypso-layout-masterbar-checkout                                            -30 B  (-0.0%)      -14 B  (-0.1%)
async-load-calypso-blocks-editor-checkout-modal                                         -30 B  (-0.0%)      +95 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       -25 B  (-0.0%)      +21 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -25 B  (-0.0%)      +21 B  (+0.0%)
async-load-design-blocks                                                                -25 B  (-0.0%)       -8 B  (-0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                        -25 B  (-0.1%)       -7 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires
Copy link
Contributor Author

DOTCOM PR 170435-ghe-Automattic/wpcom

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and I ran through the existing migration flow to make sure it's still working with this branch.

@gabrielcaires
Copy link
Contributor Author

Backend merge

@gabrielcaires gabrielcaires merged commit e15b129 into trunk Jan 23, 2025
11 of 13 checks passed
@gabrielcaires gabrielcaires deleted the update/remove-migration-flow branch January 23, 2025 17:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Migration: Delete all code related to the /setup/migration flow
3 participants