Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Use className instead of class. #98523

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

spsiddarthan
Copy link
Contributor

@spsiddarthan spsiddarthan commented Jan 17, 2025

Related to #98479 (comment) as reported by @ciampo

Proposed Changes

  • Use className instead of class

Why are these changes being made?

  • To avoid React warnings.

Testing Instructions

  • On localhost, navigate to the reader and see the warning in the console on trunk regarding className.
Screenshot 2025-01-17 at 10 11 26 AM
  • Switch to this branch and see that the warning disappears.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@spsiddarthan spsiddarthan self-assigned this Jan 17, 2025
@spsiddarthan spsiddarthan marked this pull request as ready for review January 17, 2025 04:34
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/react-warning on your sandbox.

@spsiddarthan spsiddarthan requested a review from a team January 17, 2025 04:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
@spsiddarthan
Copy link
Contributor Author

Seems to have fixed the warning, so I am merging this.

@spsiddarthan spsiddarthan changed the title Toolbar: Use class instead of className. Toolbar: Use className instead of class. Jan 17, 2025
@spsiddarthan spsiddarthan merged commit b16e472 into trunk Jan 17, 2025
21 checks passed
@spsiddarthan spsiddarthan deleted the fix/react-warning branch January 17, 2025 04:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants