Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Marketplace: Product card redesign #98529

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Jan 17, 2025

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1639

Proposed Changes

This PR updates the product cards on the marketplace according to the new design.

Why are these changes being made?

  • To match the UI with the latest product page redesign

Note: We will add the badges in a different PR. We also need to decide if we want to continue with the existing design for the discount. @madebynoam

Testing Instructions

  • Open the A4A live link
  • Go to Marketplace: Products > Append the URL with ?flags=-a4a-product-page-redesign and verify it matches the production version. There is a slight difference in the width, which is negligible and ignored.
  • Remove the feature flag > Verify the product cards are updated, as shown below.
Screenshot 2025-01-17 at 10 27 26 AM Screenshot 2025-01-17 at 10 27 36 AM Screenshot 2025-01-17 at 10 28 21 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team January 17, 2025 05:52
@yashwin yashwin self-assigned this Jan 17, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 17, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~71 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace       +363 B  (+0.0%)      +44 B  (+0.0%)
jetpack-cloud-partner-portal        +17 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-manage-pricing        +17 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants