Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Update colors so they match Modern (default) color scheme. #98542

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jasmussen
Copy link
Member

@jasmussen jasmussen commented Jan 17, 2025

Related to https://github.com/Automattic/dotcom-forge/issues/8519

Proposed Changes

Updates masterbar colors to match the Modern color scheme, which is the default admin color scheme.

Before

Screenshot 2025-01-17 at 14 29 57

Screenshot 2025-01-17 at 14 30 04

Screenshot 2025-01-17 at 14 30 36

After

Screenshot 2025-01-17 at 14 25 21

Screenshot 2025-01-17 at 14 25 31

Screenshot 2025-01-17 at 14 25 59

Why are these changes being made?

There are color scheme colors from individual site installs, and then global Calypso styles. Over time, colors have drifted out of sync, likely as default admin color schemes have been updated, and changed.

This PR fixes issues with the Modern color scheme (there was a contrast issue with the unread bell), and syncs up the color schemes applied to Calypso (Reader, Me, Sites) so they match the default Modern color scheme.

That specifically includes updating the grays. The default shades of gray in the WordPress design system (as defined here) are not yet in Color Studio, and must therefore be defined inline. CC: @Automattic/dotcom-design

Testing Instructions

Apply the PR, then test the wp-admin sections, such as Users > Profile, as well as Reader, Me, and Sites, to see if the colors of the adminbar/masterbar match.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jasmussen jasmussen self-assigned this Jan 17, 2025
@jasmussen jasmussen added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jan 17, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants