Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of the ticket not being created for sites already on WPCOM #98548

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

valterlorran
Copy link
Contributor

Related to #

Proposed Changes

  • Fixes the issue that would not allow the user to answer the survey in case the site was already on WPCOM.
  • Added a new Async mutation for creating the Ticket.
  • Removed a few checks that are no longer necessary.

Why are these changes being made?

  • While testing the flow, I noticed that we were not able to submit the survey when the site was already on WPCOM. After investigation, I noticed that the survey required the ticket to be created to store the survey. The ticket was not being created on the credentials step in the cases in which the site was already on WPCOM.

Testing Instructions

  • Use the Calypso Live link below
  • Go through the Migration flow until you reach the Credentials step.
  • Input a WordPress.com site as the source site for the migration
  • Submit the credentials step, you should be redirected to the "Your site is already on WPCOM" step survey.
  • Complete the survey and submit it.
  • You should not see an error
  • Verify that the ticket was created and updated.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested review from Imran92 and a team January 17, 2025 14:43
@valterlorran valterlorran self-assigned this Jan 17, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 17, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow        +32 B  (+0.0%)       +8 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jan 17, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/create-ticket-already-wpcom-step on your sandbox.

from_url: from,
} );
onSubmit( siteInfoResult );
} else if ( isNotWordPress( siteInfoResult ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we skipping the ticket creation if the site is not on WordPress? They already got to the flow and clicked submit, so probably worth to follow up with a ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants