Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: display a pointer cursor for the sidebar menu toggle button #98651

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Jan 21, 2025

Follow-up to #98510

Proposed Changes

  • Change cursor to pointer for the sidebar menu trigger button in the masterbar

Why are these changes being made?

  • For consistency with how pointers are displayed for other buttons across the site

Testing Instructions

  • Load any page displaying the masterbar (eg. the home dashboard of any site)
  • Resize the viewport to a width below 780px
  • On a device with a pointer (ie. not a touch screen device), hover over the sidebar menu trigger button
  • Make sure the pointer cursor is shown

Screenshot 2025-01-21 at 10 36 17

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 21, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/masterbar-sidebar-menu-trigger-cursor-pointer on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ciampo ciampo mentioned this pull request Jan 21, 2025
11 tasks
@ciampo ciampo self-assigned this Jan 21, 2025
@ciampo ciampo requested a review from a team January 21, 2025 10:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
@ciampo ciampo added [Type] Janitorial Masterbar and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 21, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
@ciampo ciampo added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Jan 21, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
@ciampo ciampo marked this pull request as ready for review January 21, 2025 10:18
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍 🚀

@ciampo ciampo force-pushed the fix/masterbar-sidebar-menu-trigger-cursor-pointer branch from c27c531 to 6379603 Compare January 21, 2025 12:34
@ciampo ciampo force-pushed the fix/masterbar-sidebar-menu-trigger-cursor-pointer branch from 6379603 to 4fa83e9 Compare January 21, 2025 15:48
@ciampo ciampo merged commit 7abf48b into trunk Jan 21, 2025
12 checks passed
@ciampo ciampo deleted the fix/masterbar-sidebar-menu-trigger-cursor-pointer branch January 21, 2025 16:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Masterbar [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants