Refactor Woo state selectors

[chihsuan]

Proposed Changes

Currently, we have the following selectors:

• getIsWooPasswordless: Check if it's Woo passwordless should be enabled or not.
• isWooPasswordlessJPCFlow: Check if it's Woo Jetpack Connection Flow
• isWooOAuth2Client: Check if it's Woo (but not WOO JPC Flow)
• isPartnerSignupQuery: Check if it's partner signup via https://woocommerce.com/partner-signup

Since we've removed the passwordless feature flags in base branch, we can simplify the selectors to the following:

• getIsWoo: Return if it's Woo (either via WCCOM or WOO JPC Flow)
• getIsWCCOM: Return if it's from WooCommerce.com
• isWooJPCFlow: Return if it's Woo Jetpack Connection Flow

Also, the partner signup has been removed (https://woocommerce.com/partner-signup) (p1709724073968639/1709671857.265099-slack-C07418EA0), so we can remove isPartnerSignupQuery selector and related code

Why are these changes being made?

• Make it easier to understand and maintain

Testing Instructions

• Checkout this branch
• Set up Woo start env
• Go to woocommerce.com
• Click "Log in" in the header
• Test the signup/login flow and confirm it remains unchanged
• Create a WooCommerce site and complete the core profiler
• Test core profiler Wordpress.com connection flow and confirm remains unchanged

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131590

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131590&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131590&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/refactor-woo-selectors on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1085 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-login                -4531 B  (-0.2%)    -1057 B  (-0.2%)
entry-main                 -4335 B  (-0.2%)    -1552 B  (-0.3%)
entry-subscriptions         -185 B  (-0.0%)      -76 B  (-0.0%)
entry-stepper               -126 B  (-0.0%)      -46 B  (-0.0%)
entry-domains-landing       -126 B  (-0.0%)      -47 B  (-0.0%)
entry-browsehappy           -126 B  (-0.1%)      -47 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1312 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
github-deployments                   +2929 B  (+0.2%)     +940 B  (+0.2%)
site-blocks                          +2916 B  (+0.5%)     +937 B  (+0.5%)
security                             +2916 B  (+0.4%)     +937 B  (+0.4%)
purchases                            +2916 B  (+0.1%)     +937 B  (+0.1%)
privacy                              +2916 B  (+0.5%)     +937 B  (+0.6%)
notification-settings                +2916 B  (+0.4%)     +937 B  (+0.5%)
me                                   +2916 B  (+0.5%)     +937 B  (+0.6%)
help                                 +2916 B  (+0.5%)     +937 B  (+0.6%)
developer                            +2916 B  (+0.5%)     +937 B  (+0.6%)
checkout                             +2916 B  (+0.2%)     +943 B  (+0.2%)
account-close                        +2916 B  (+0.5%)     +937 B  (+0.6%)
account                              +2916 B  (+0.4%)     +937 B  (+0.4%)
site-tools                           +2713 B  (+0.2%)     +899 B  (+0.2%)
accept-invite                        +1677 B  (+0.9%)     +793 B  (+1.5%)
stepper-user-step                    -1107 B  (-0.4%)     -341 B  (-0.4%)
jetpack-connect                      -1019 B  (-0.1%)     +408 B  (+0.1%)
link-in-bio-tld-flow                  -687 B  (-0.0%)      -93 B  (-0.0%)
update-design-flow                    -412 B  (-0.0%)      -26 B  (-0.0%)
signup                                -412 B  (-0.1%)      -26 B  (-0.0%)
write-flow                            -275 B  (-0.0%)      -67 B  (-0.0%)
build-flow                            -275 B  (-0.0%)      -67 B  (-0.0%)
plugins                               -228 B  (-0.0%)      -66 B  (-0.0%)
themes                                -216 B  (-0.0%)      -38 B  (-0.0%)
staging-site                          -216 B  (-0.0%)      -41 B  (-0.0%)
site-settings                         -216 B  (-0.0%)      -39 B  (-0.0%)
site-marketing                        -216 B  (-0.0%)      -39 B  (-0.0%)
settings-security                     -216 B  (-0.0%)      -37 B  (-0.0%)
settings-podcast                      -216 B  (-0.0%)      -39 B  (-0.0%)
settings-performance                  -216 B  (-0.0%)      -43 B  (-0.0%)
settings                              -216 B  (-0.0%)      -39 B  (-0.0%)
posts-custom                          -216 B  (-0.0%)      -41 B  (-0.0%)
posts                                 -216 B  (-0.0%)      -41 B  (-0.0%)
marketing                             -216 B  (-0.0%)      -39 B  (-0.0%)
jetpack-cloud-plugin-management       -216 B  (-0.0%)      -61 B  (-0.0%)
hosting                               -216 B  (-0.0%)      -41 B  (-0.0%)
earn                                  -216 B  (-0.0%)      -39 B  (-0.0%)
domains                               -216 B  (-0.0%)      -41 B  (-0.0%)
activity                              -216 B  (-0.0%)      -39 B  (-0.0%)
a8c-for-agencies-plugins              -216 B  (-0.0%)      -61 B  (-0.0%)
import-hosted-site-flow                -59 B  (-0.0%)      -27 B  (-0.0%)
purchase-product                       -48 B  (-0.0%)      -10 B  (-0.0%)
media                                  -12 B  (-0.0%)       -5 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~95 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-blocks-editor-checkout-modal                                       +2916 B  (+0.2%)     +943 B  (+0.3%)
async-load-signup-steps-user                                                          -2025 B  (-0.8%)     -339 B  (-0.5%)
async-load-signup-steps-page-picker                                                    -648 B  (-0.2%)     -995 B  (-0.7%)
async-load-purchase-modal-wrapper                                                      -648 B  (-0.2%)     -985 B  (-0.8%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       -596 B  (-0.2%)     -912 B  (-0.8%)
async-load-calypso-my-sites-checkout-modal                                             -555 B  (-0.0%)     -342 B  (-0.1%)
async-load-calypso-reader-sidebar                                                      -216 B  (-0.2%)      -39 B  (-0.2%)
async-load-calypso-my-sites-current-site-notice                                        -216 B  (-0.4%)      -41 B  (-0.2%)
async-load-calypso-components-web-preview-component                                    -216 B  (-0.1%)      -42 B  (-0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                                -216 B  (-0.4%)      -37 B  (-0.2%)
async-load-calypso-blocks-jitm-templates-notice                                        -216 B  (-0.4%)      -38 B  (-0.2%)
async-load-calypso-blocks-jitm-templates-default                                       -216 B  (-0.4%)      -40 B  (-0.2%)
async-load-design-blocks                                                               -191 B  (-0.0%)     +508 B  (+0.1%)
async-load-calypso-blocks-login-two-factor-authentication-two-factor-content           -173 B  (-0.9%)      -75 B  (-1.2%)
async-load-signup-steps-site                                                            -59 B  (-0.1%)      -26 B  (-0.1%)
async-load-signup-steps-p2-site                                                         -59 B  (-0.1%)      -25 B  (-0.1%)
async-load-signup-steps-p2-details                                                      -59 B  (-0.1%)      -26 B  (-0.1%)
async-load-design-playground                                                            -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-design                                                                       -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-calypso-post-editor-media-modal                                              -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal                                       -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-calypso-blocks-login-lost-password-form                                      -12 B  (-0.4%)       -7 B  (-0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[moon0326]

Thank you for working on this refactoring 🙇‍♂️. It looks good to me (LGTM) and has been tested well.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220599

Some locales (Hebrew, Indonesian, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @chihsuan for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.