Stats Location: update geochart to use coordinates for Regions and Cities #99142

Initsogar · 2025-01-31T03:48:56Z

Related to https://github.com/Automattic/jetpack-roadmap/issues/2242

Proposed Changes

Use coordinates to render markers for cities and regions in Geochart.

Note

The regions API doesn’t return coordinates yet, but the idea is to have the code ready for when they become available.

Why are these changes being made?

We tried an approach that uses geocoding to obtain coordinates from the Google Maps API. The goal is to use the coordinates available in our Locations API to avoid relying on the Google Maps API.

Testing Instructions

Spin up Calypso Live Branch.
Navigate to the Stats page.
Ensure that switching to the Cities tab renders the markers quickly.
Try to see the Cities tab on the summary/detailed page, and try some country filters.
The regions tab should not draw any marker.
Using a site with WordPress.com Personal plan, you can validate the Regions and Cities tabs are gated and loads markers in the blurry map.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-01-31T03:49:10Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131883

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131883&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131883&env=a8c-for-agencies

matticbot · 2025-01-31T03:56:15Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/stats-locations-cities-map on your sandbox.

matticbot · 2025-01-31T03:57:46Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~281 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
stats                                   +813 B  (+0.1%)     +281 B  (+0.1%)
woocommerce-installation                 +46 B  (+0.0%)      +18 B  (+0.0%)
woocommerce                              +46 B  (+0.0%)      +18 B  (+0.0%)
themes                                   +46 B  (+0.0%)      +18 B  (+0.0%)
theme                                    +46 B  (+0.0%)      +18 B  (+0.0%)
subscribers                              +46 B  (+0.0%)      +18 B  (+0.0%)
staging-site                             +46 B  (+0.0%)      +18 B  (+0.0%)
sites-dashboard                          +46 B  (+0.0%)      +18 B  (+0.0%)
site-tools                               +46 B  (+0.0%)      +18 B  (+0.0%)
site-settings                            +46 B  (+0.0%)      +18 B  (+0.0%)
site-purchases                           +46 B  (+0.0%)      +18 B  (+0.0%)
site-performance                         +46 B  (+0.0%)      +18 B  (+0.0%)
site-overview                            +46 B  (+0.0%)      +18 B  (+0.0%)
site-monitoring                          +46 B  (+0.0%)      +18 B  (+0.0%)
site-marketing                           +46 B  (+0.0%)      +18 B  (+0.0%)
site-logs                                +46 B  (+0.0%)      +18 B  (+0.0%)
settings-writing                         +46 B  (+0.0%)      +18 B  (+0.0%)
settings-security                        +46 B  (+0.0%)      +18 B  (+0.0%)
settings-reading                         +46 B  (+0.0%)      +18 B  (+0.0%)
settings-podcast                         +46 B  (+0.0%)      +18 B  (+0.0%)
settings-performance                     +46 B  (+0.0%)      +18 B  (+0.0%)
settings-newsletter                      +46 B  (+0.0%)      +18 B  (+0.0%)
settings-jetpack                         +46 B  (+0.0%)      +18 B  (+0.0%)
settings-discussion                      +46 B  (+0.0%)      +18 B  (+0.0%)
settings                                 +46 B  (+0.0%)      +18 B  (+0.0%)
scan                                     +46 B  (+0.0%)      +18 B  (+0.0%)
purchases                                +46 B  (+0.0%)      +18 B  (+0.0%)
promote-post-i2                          +46 B  (+0.0%)      +18 B  (+0.0%)
preview                                  +46 B  (+0.0%)      +18 B  (+0.0%)
posts-custom                             +46 B  (+0.0%)      +18 B  (+0.0%)
posts                                    +46 B  (+0.0%)      +18 B  (+0.0%)
plugins                                  +46 B  (+0.0%)      +18 B  (+0.0%)
plans                                    +46 B  (+0.0%)      +18 B  (+0.0%)
people                                   +46 B  (+0.0%)      +18 B  (+0.0%)
pages                                    +46 B  (+0.0%)      +18 B  (+0.0%)
migrate                                  +46 B  (+0.0%)      +18 B  (+0.0%)
media                                    +46 B  (+0.0%)      +18 B  (+0.0%)
marketplace                              +46 B  (+0.0%)      +18 B  (+0.0%)
marketing                                +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-social                           +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-search                           +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-connect                          +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-settings                   +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-pricing                    +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-plugin-management          +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-overview                   +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-features-comparison        +46 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud                            +46 B  (+0.0%)      +18 B  (+0.0%)
import                                   +46 B  (+0.0%)      +18 B  (+0.0%)
hosting-features                         +46 B  (+0.0%)      +18 B  (+0.0%)
hosting                                  +46 B  (+0.0%)      +18 B  (+0.0%)
home                                     +46 B  (+0.0%)      +18 B  (+0.0%)
gutenberg-editor                         +46 B  (+0.0%)      +18 B  (+0.0%)
google-my-business                       +46 B  (+0.0%)      +18 B  (+0.0%)
github-deployments                       +46 B  (+0.0%)      +18 B  (+0.0%)
export                                   +46 B  (+0.0%)      +18 B  (+0.0%)
email                                    +46 B  (+0.0%)      +18 B  (+0.0%)
earn                                     +46 B  (+0.0%)      +18 B  (+0.0%)
domains                                  +46 B  (+0.0%)      +18 B  (+0.0%)
customize                                +46 B  (+0.0%)      +18 B  (+0.0%)
concierge                                +46 B  (+0.0%)      +18 B  (+0.0%)
comments                                 +46 B  (+0.0%)      +18 B  (+0.0%)
checkout                                 +46 B  (+0.0%)      +18 B  (+0.0%)
backup                                   +46 B  (+0.0%)      +18 B  (+0.0%)
add-ons                                  +46 B  (+0.0%)      +18 B  (+0.0%)
activity                                 +46 B  (+0.0%)      +18 B  (+0.0%)
a8c-for-agencies-plugins                 +46 B  (+0.0%)      +18 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

…into fix/stats-locations-cities-map

…cities-map

Initsogar · 2025-02-04T02:59:56Z

client/my-sites/stats/features/modules/stats-locations/stats-locations.tsx

@@ -209,22 +210,9 @@ const StatsLocations: React.FC< StatsModuleLocationsProps > = ( { query, summary
 		</StatsInfoArea>
 	);

-	const fakeData = [


We needed to add coordinates, and I think it’s too much data to keep in this file, so I preferred to move it to its own sample-locations.js file.

myhro

Nice work, Rafa! I'm approving it, as it LGTM, and we can roll it out as soon as we get support for Regions coordinates. ✅

Ensure that switching to the Cities tab renders the markers quickly.

Not just quickly, but instantly with no network requests:

Try to see the Cities tab on the summary/detailed page, and try some country filters.

The regions tab should not draw any marker.

Using a site with WordPress.com Personal plan, you can validate the Regions and Cities tabs are gated and loads markers in the blurry map.

Initsogar · 2025-02-04T14:34:15Z

As discussed in sync, we will proceed with merging this PR even if the coordinates for regions are not ready yet. However, since this PR enables support for them in Stats, we shouldn’t need to create another PR once they are ready.

If we decide to pivot to a different approach, we will prepare a new PR accordingly.

…ties (#99142) * Stats: add subdivisions tooltip * Update geochart to accept coordinates for Cities view * Omit coordinates property when no data exists * Handle region and city mode as markers * Filter locations with coordinates * Remove prop that is not needed for now * Refactor sample locations using coordinates * Simplify conditions * Remove unused attribute to sample locations --------- Co-authored-by: Tiago Ilieve <[email protected]>

myhro and others added 2 commits January 30, 2025 15:11

Stats: add subdivisions tooltip

7979548

Update geochart to accept coordinates for Cities view

15af789

Initsogar added the [Status] In Progress label Jan 31, 2025

Initsogar self-assigned this Jan 31, 2025

Initsogar added 9 commits January 30, 2025 23:41

Omit coordinates property when no data exists

f5d779a

Merge remote-tracking branch 'origin/add/stats-subdivisions-tooltip' …

4af5a54

…into fix/stats-locations-cities-map

Merge remote-tracking branch 'origin/trunk' into fix/stats-locations-…

1e843d1

…cities-map

Merge remote-tracking branch 'origin/trunk' into fix/stats-locations-…

f333418

…cities-map

Handle region and city mode as markers

439027a

Filter locations with coordinates

eef82f5

Merge remote-tracking branch 'origin/trunk' into fix/stats-locations-…

2793c0a

…cities-map

Remove prop that is not needed for now

5607aae

Refactor sample locations using coordinates

232f2a3

Initsogar commented Feb 4, 2025

View reviewed changes

Initsogar changed the title ~~Stats Location: update geochart to use coordinates for Cities view~~ Stats Location: update geochart to use coordinates for Regions and Cities Feb 4, 2025

Initsogar requested a review from myhro February 4, 2025 03:12

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2025

Initsogar added [Feature] Stats Everything related to our analytics product at /stats/ and removed [Status] In Progress labels Feb 4, 2025

Initsogar added 2 commits February 3, 2025 22:17

Simplify conditions

0856d41

Remove unused attribute to sample locations

0e8c759

myhro approved these changes Feb 4, 2025

View reviewed changes

Initsogar merged commit 7b2982e into trunk Feb 4, 2025
13 checks passed

Initsogar deleted the fix/stats-locations-cities-map branch February 4, 2025 15:01

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stats Location: update geochart to use coordinates for Regions and Cities #99142

Stats Location: update geochart to use coordinates for Regions and Cities #99142

Initsogar commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited by matticbot

Loading

matticbot commented Jan 31, 2025 •

edited

Loading

matticbot commented Jan 31, 2025 •

edited

Loading

Initsogar Feb 4, 2025

myhro left a comment

Initsogar commented Feb 4, 2025

Stats Location: update geochart to use coordinates for Regions and Cities #99142

Stats Location: update geochart to use coordinates for Regions and Cities #99142

Conversation

Initsogar commented Jan 31, 2025 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jan 31, 2025 • edited by matticbot Loading

matticbot commented Jan 31, 2025 • edited Loading

matticbot commented Jan 31, 2025 • edited Loading

Initsogar Feb 4, 2025

Choose a reason for hiding this comment

myhro left a comment

Choose a reason for hiding this comment

Initsogar commented Feb 4, 2025

Initsogar commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited by matticbot

Loading

matticbot commented Jan 31, 2025 •

edited

Loading

matticbot commented Jan 31, 2025 •

edited

Loading