Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Add natural arrow navigation #99176

Closed
wants to merge 2 commits into from

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Jan 31, 2025

Related to: https://github.com/Automattic/jetpack-roadmap/issues/2180

Proposed Changes

Adds detection for month-to-date and year-to-date shortcuts when navigating to the previous period. Additionally, recognize natural month boundaries and jump backwards and forwards by the expected amount.

Of note, this PR does not add bounds checks to the forward navigation. It is still possible to move forward by a period that ends in the future.

Why are these changes being made?

Should make for more natural default navigation behaviours.

Testing Instructions

  • Select Year-to-date, click previous arrow, see all of the previous year
  • Select Month-to-date, click previous arrow, see all of the previous month
  • Continue to click the previous arrow, date should fall on month boundaries — ie: Jan → Dec → Nov
  • Click next arrow; see full months — ie: Nov → Dec → Jan

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@a8ck3n a8ck3n marked this pull request as ready for review January 31, 2025 17:57
@a8ck3n a8ck3n requested a review from a team January 31, 2025 17:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@a8ck3n a8ck3n requested a review from ederrengifo January 31, 2025 17:58
@a8ck3n a8ck3n self-assigned this Jan 31, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 31, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~138 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats      +1316 B  (+0.1%)     +138 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~138 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-store-app-store-stats-listview      +1316 B  (+1.1%)     +138 B  (+0.4%)
async-load-store-app-store-stats               +1316 B  (+0.5%)     +138 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-natural-arrow-navigation on your sandbox.

@a8ck3n a8ck3n marked this pull request as draft January 31, 2025 18:02
@a8ck3n
Copy link
Contributor Author

a8ck3n commented Jan 31, 2025

And now I'm seeing that we already have an open PR addressing this one. Will pause this and have a look at that one first.

#99140

@kangzj
Copy link
Contributor

kangzj commented Feb 2, 2025

Closing as #99140 has shipped.

@kangzj kangzj closed this Feb 2, 2025
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants