-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Add natural arrow navigation #99176
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~138 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~138 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
And now I'm seeing that we already have an open PR addressing this one. Will pause this and have a look at that one first. |
Closing as #99140 has shipped. |
Related to: https://github.com/Automattic/jetpack-roadmap/issues/2180
Proposed Changes
Adds detection for month-to-date and year-to-date shortcuts when navigating to the previous period. Additionally, recognize natural month boundaries and jump backwards and forwards by the expected amount.
Of note, this PR does not add bounds checks to the forward navigation. It is still possible to move forward by a period that ends in the future.
Why are these changes being made?
Should make for more natural default navigation behaviours.
Testing Instructions
Pre-merge Checklist