Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings page redirects to wp-admin for duplicate view experiment #99321

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Feb 5, 2025

Related to #98875, Automattic/jetpack#40913, #98664

Proposed Changes

This is a follow-up for #98875, redirecting settings pages from Calypso to wp-admin when the experiment is enabled.

Note

It'd be nicer to deploy this PR after Automattic/jetpack#40913 lands on Atomic.

Why are these changes being made?

Please refer to p7DVsv-mbN-p2

Testing Instructions

  • Add yourself to the treatment group via 22167-explat-experiment
  • Prepare a site with the Default interface style
  • Observe the following redirections:
Screenshot 2025-02-05 at 15 59 25

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Feb 5, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~187 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
settings-discussion        +101 B  (+0.0%)      +31 B  (+0.0%)
settings-writing            +98 B  (+0.0%)      +37 B  (+0.0%)
settings-reading            +98 B  (+0.0%)      +38 B  (+0.0%)
settings-security           +66 B  (+0.0%)      +16 B  (+0.0%)
settings-podcast            +66 B  (+0.0%)      +30 B  (+0.0%)
settings-performance        +66 B  (+0.0%)      +19 B  (+0.0%)
settings-newsletter         +66 B  (+0.0%)      +30 B  (+0.0%)
settings-jetpack            +66 B  (+0.0%)      +22 B  (+0.0%)
settings                    +66 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from add/hosting-menu-site-setting to trunk February 5, 2025 06:41
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/wp-admin-redirects on your sandbox.

@okmttdhr okmttdhr self-assigned this Feb 5, 2025
@okmttdhr okmttdhr marked this pull request as ready for review February 5, 2025 07:36
@lsl lsl force-pushed the update/wp-admin-redirects branch from e25031d to e70cb06 Compare February 5, 2025 23:10
@@ -93,7 +94,7 @@ export async function redirectGeneralSettingsIfDuplicatedViewsEnabled( context,
return page.redirect( `/sites/settings/site/${ siteSlug }` );
}
Copy link
Contributor

@lsl lsl Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this redirect is wrong, we should be updating the classic view menu item on the JP side instead of doing a redirect here. Will follow up.

I'd like it if /settings/general always redirects to options-general.php no matter what site / view you're on.

At the moment, /settings/general will take you to two different places depending on if you're classic view or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsl
Copy link
Contributor

lsl commented Feb 6, 2025

Tested each of these redirects, lets follow up to remove the special case redirect on classic view /settings/general

@lsl lsl merged commit 2ce2877 into trunk Feb 6, 2025
13 checks passed
@lsl lsl deleted the update/wp-admin-redirects branch February 6, 2025 02:25
JessBoctor pushed a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants