-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings page redirects to wp-admin for duplicate view experiment #99321
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~187 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
e25031d
to
e70cb06
Compare
@@ -93,7 +94,7 @@ export async function redirectGeneralSettingsIfDuplicatedViewsEnabled( context, | |||
return page.redirect( `/sites/settings/site/${ siteSlug }` ); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this redirect is wrong, we should be updating the classic view menu item on the JP side instead of doing a redirect here. Will follow up.
I'd like it if /settings/general always redirects to options-general.php no matter what site / view you're on.
At the moment, /settings/general will take you to two different places depending on if you're classic view or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested each of these redirects, lets follow up to remove the special case redirect on classic view /settings/general |
…#99321) Co-authored-by: Louis Laugesen <[email protected]>
Related to #98875, Automattic/jetpack#40913, #98664
Proposed Changes
This is a follow-up for #98875, redirecting settings pages from Calypso to wp-admin when the experiment is enabled.
Note
It'd be nicer to deploy this PR after Automattic/jetpack#40913 lands on Atomic.
Why are these changes being made?
Please refer to p7DVsv-mbN-p2
Testing Instructions
Pre-merge Checklist