Redirect to /settings/general if the RDV experiment is DISABLED

[okmttdhr]

Related to p1739023467265609-slack-C07H21B2W59, #99388, #98875, https://github.com/Automattic/dotcom-forge/issues/10387

Proposed Changes

This PR changes to redirect from /sites/settings/site to /settings/general if the Remove Duplicated Views (RDV) experiment is DISABLED. This prevents RDV control users from encountering the broken Settings tab.

Why are these changes being made?

p1739170725703829/1739159536.734729-slack-CRWCHQGUB

Testing Instructions

1. Ensure you have access to the RDV experiment flags.
   • Toggle the RDV experiment between treatment and control via 22167-explat-experiment
2. Verify behavior for users in the treatment group (RDV enabled):
   • Default Interface sites:
     • Navigating to /settings/general should redirect to options-general.php.
     • Navigating to /sites/settings/site should stay at /sites/settings/site.
   • Classic Interface sites:
     • Navigating to /settings/general should redirect to /sites/settings/site.
     • Navigating to /sites/settings/site should stay at /sites/settings/site. (extra context in Make Site Settings available to duplicate views experiment users  #98875 "Redirection logic" and Fix classic style site settings menu item #99391
3. Verify behavior for users in the control group (RDV disabled):
   • Default Interface sites:
     • 🆕 Navigating to /sites/settings/site should redirect to /settings/general.
     • Navigating to /settings/general should stay at /settings/general.
   • Classic Interface sites:
     • 🆕 Navigating to /sites/settings/site should redirect to /settings/general.
     • Navigating to /settings/general should stay at /settings/general.

Additional Regression Tests:

Treatment Group (RDV Enabled)

• Default Interface Sites:
  • Calypso:
    • New Settings tab appears in the Hosting Dashboard.
    • Navigating to Settings > General redirects to options-general.php.
  • wp-admin:
    • options-general.php contains a link to /sites/settings/site (WordPress.com Site Settings).
    • options-reading.php contains a link to /sites/settings/site (Site Visibility).
• Classic Interface Sites:
  • Same behavior as Default Interface Sites.

Control Group (RDV Disabled)

• Default Interface Sites:
  • Calypso:
    • Old Server Settings tab appears in the Hosting Dashboard.
    • Navigating to Settings > General should be at /settings/general.
  • wp-admin:
    • options-general.php should not contain a link to /sites/settings/site (WordPress.com Site Settings).
    • options-reading.php should not contain a link to /sites/settings/site (Site Visibility).
• Classic Interface Sites:
  • Calypso:
    • Old Server Settings tab appears in the Hosting Dashboard.
    • Navigating to Settings > General should be at /settings/general (Hosting > Site Settings).
  • wp-admin:
    • Same behavior as Default Interface Sites.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132558

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132558&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132558&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/rdv-redirect on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~809 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
site-settings             +4495 B  (+0.3%)    +1205 B  (+0.3%)
settings-writing           +128 B  (+0.0%)      +37 B  (+0.0%)
settings-security          +128 B  (+0.0%)      +25 B  (+0.0%)
settings-reading           +128 B  (+0.0%)      +30 B  (+0.0%)
settings-podcast           +128 B  (+0.0%)      +37 B  (+0.0%)
settings-performance       +128 B  (+0.0%)      +25 B  (+0.0%)
settings-newsletter        +128 B  (+0.0%)      +37 B  (+0.0%)
settings-jetpack           +128 B  (+0.0%)      +29 B  (+0.0%)
settings-discussion        +128 B  (+0.0%)      +29 B  (+0.0%)
settings                   +128 B  (+0.0%)      +56 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[lsl]

LGTM

🆕 Navigating to /settings/general should redirect to /sites/settings/site.

Assuming this is only temporary until #99391 can be completed?

[okmttdhr]

🆕 Navigating to /settings/general should redirect to /sites/settings/site.

Assuming this is only temporary until #99391 can be completed?

@lsl Yes, this should be a temporary behavior.
And I realized that I tagged 🆕 to the wrong items, sorry! The correct ones are the following: