Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notice hover state to be compatible with removed IsReskinned flag #99542

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Feb 10, 2025

Follow-up of #99112
Related to the Focused Launchpad: pet6gk-1T7-p2

Proposed Changes

  • We're updating the hover state color for buttons inside Notices:

Before:

Screen.Recording.2025-02-10.at.09.22.10.mov

After:

Screen.Recording.2025-02-10.at.09.30.46.mov

Why are these changes being made?

  • This is a follow-up of removed IsSkinned. The background color now is light compared to the old dark one, so the hover effect needs to be updated.

Testing Instructions

  • Go to /setup/onboarding
  • Complete the onboarding process
  • When in the launchpad, replace the URL to the /home page adding the extra flag parameter: flags=home/launchpad-first
  • Edit the page's title
  • Check if the new style is correct

Or follow the video:

Screen.Recording.2025-02-10.at.10.46.43.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 requested review from ddc22 and a team February 10, 2025 13:50
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hover-state-on-notice on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@zaguiini zaguiini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I don't like the looks of the notice. It's difficult to distinguish it from the background, and the inactive "Next steps" link doesn't have a lot of contrast. Do we plan to refactor that component completely anytime soon? cc @nuriapenya

@@ -282,7 +282,7 @@ a.notice__action {
}

&:hover {
color: var(--color-text-inverted);
color: var(--studio-gray-80);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a color token instead of a color code? It would be --color-accent-80 in this case, but it would be even better if we could use an explicit --hover token.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we had another layout in mind before the last week's changes: p9Jlb4-fmP-p2

cc @nuriapenya

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am trying to track down at what point we changed the Calypso notice to look "lighter". I agree with @zaguiini , it's currently not visible. Started a thread here in Slack: p1739002922765779-slack-C9EJ7KSGH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that discussion in Slack, but since this is currently broken in production I feel like I should merge this quick fix.

@p-jackson p-jackson merged commit 6e9d249 into trunk Feb 11, 2025
17 checks passed
@p-jackson p-jackson deleted the update/hover-state-on-notice branch February 11, 2025 06:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants