Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create course goal] POC: Use plugin-bundle flow to install sensei #99749

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Feb 13, 2025

Similar to #99671 but now using the plugin-bundle flow.
It also introduce changes the following changes on the plugin-bundle flow :

  • Support install new software sets not related to an specific theme.
  • Skip the domain change confirmation step based on the skipConfirmation flag

Testing Instructions

@gabrielcaires gabrielcaires changed the title POC: Use plugin-bundle flow to install sensei [CREATE COURSE GOAL] POC: Use plugin-bundle flow to install sensei Feb 13, 2025
@gabrielcaires gabrielcaires changed the title [CREATE COURSE GOAL] POC: Use plugin-bundle flow to install sensei [Create course goal] POC: Use plugin-bundle flow to install sensei Feb 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug poc/use-bundle-plugin-flow on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~589 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +5209 B  (+0.4%)     +179 B  (+0.0%)
entry-login                -1528 B  (-0.1%)      +86 B  (+0.0%)
entry-subscriptions        -1397 B  (-0.1%)     -194 B  (-0.0%)
entry-domains-landing      -1397 B  (-0.2%)     -194 B  (-0.1%)
entry-browsehappy          -1397 B  (-0.7%)     -194 B  (-0.3%)
entry-main                  -476 B  (-0.0%)     +211 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~63632 bytes added 📈 [gzipped])

name                             parsed_size             gzip_size
transferring-hosted-site-flow      +316732 B  (+128.1%)   +92926 B  (+116.9%)
build-flow                         +110227 B    (+9.5%)   +36409 B   (+10.3%)
write-flow                         +109118 B    (+8.1%)   +34930 B    (+8.4%)
earn                                +85792 B   (+10.9%)   +28837 B   (+12.2%)
subscribers                         +73948 B    (+5.4%)   +24961 B    (+6.7%)
link-in-bio-tld-flow                +73243 B    (+3.3%)   +24801 B    (+3.8%)
home                                +49065 B    (+2.8%)   +16149 B    (+3.1%)
plugin-bundle-flow                    +864 B    (+0.2%)    -2172 B    (-1.4%)
start-writing-flow                    +461 B    (+1.7%)     +111 B    (+2.0%)
newsletter-flow                       +461 B    (+2.1%)      +90 B    (+1.7%)
design-first-flow                     +461 B    (+1.6%)     +104 B    (+1.8%)
stats                                 +217 B    (+0.0%)     -222 B    (-0.1%)
stepper-user-step                     +206 B    (+0.1%)      +49 B    (+0.1%)
woocommerce-installation              +195 B    (+0.1%)     +721 B    (+0.7%)
settings-performance                  +103 B    (+0.0%)       +7 B    (+0.0%)
newsletter-post-setup-flow            +103 B    (+0.0%)      +25 B    (+0.0%)
link-in-bio-post-setup-flow           +103 B    (+0.0%)      +25 B    (+0.0%)
jetpack-cloud-partner-portal          -103 B    (-0.0%)      -11 B    (-0.0%)
jetpack-cloud-manage-pricing          +103 B    (+0.0%)      +20 B    (+0.0%)
jetpack-cloud-agency-dashboard        -103 B    (-0.0%)      -11 B    (-0.0%)
domain-user-transfer-flow             +103 B    (+0.0%)      +29 B    (+0.0%)
accept-invite                         +103 B    (+0.1%)      +31 B    (+0.1%)
a8c-for-agencies-settings             +103 B    (+0.0%)      +25 B    (+0.0%)
a8c-for-agencies-landing              -103 B    (-0.1%)      -13 B    (-0.0%)
a8c-for-agencies-agency-tier          +103 B    (+0.0%)      +24 B    (+0.0%)
a8c-for-agencies                      -103 B    (-0.1%)      -12 B    (-0.0%)
update-design-flow                     +48 B    (+0.0%)     -138 B    (-0.0%)
signup                                 +22 B    (+0.0%)       +0 B
site-setup-wg                          +13 B    (+0.0%)      -35 B    (-0.0%)
site-setup-flow                        +13 B    (+0.0%)      -35 B    (-0.0%)
site-purchases                         +13 B    (+0.0%)      -52 B    (-0.0%)
purchases                              +13 B    (+0.0%)      -33 B    (-0.0%)
plugins                                +13 B    (+0.0%)       -6 B    (-0.0%)
jetpack-cloud-plugin-management        +13 B    (+0.0%)      +34 B    (+0.0%)
a8c-for-agencies-plugins               +13 B    (+0.0%)      +36 B    (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~15743 bytes added 📈 [gzipped])

name                                                 parsed_size            gzip_size
async-load-calypso-my-sites-stats-pages-subscribers     +50686 B  (+33.7%)   +15509 B  (+30.0%)
async-load-signup-steps-user                              +103 B   (+0.0%)      +34 B   (+0.0%)
async-load-signup-steps-social-profiles                   +103 B   (+0.2%)      +23 B   (+0.1%)
async-load-signup-steps-site-options                      +103 B   (+0.1%)      +20 B   (+0.1%)
async-load-signup-steps-site                              +103 B   (+0.1%)      +18 B   (+0.1%)
async-load-signup-steps-p2-site                           +103 B   (+0.1%)      +36 B   (+0.1%)
async-load-signup-steps-p2-complete-profile               +103 B   (+0.1%)      +33 B   (+0.1%)
async-load-calypso-my-sites-checkout-modal                 +39 B   (+0.0%)      +70 B   (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants