Skip to content

Fix pet invisibility #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SenPr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix pet invisibility #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a8bc9
Fix pet invisibility
SenPr Aug 15, 2023
a93f29f
add %player_name% to pet's name
SenPr Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions eco-core/core-plugin/src/main/kotlin/com/willfp/ecopets/pets/PetDisplay.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class PetDisplay(
@Suppress("DEPRECATION")
stand.customName = plugin.configYml.getString("pet-entity.name")
.replace("%player%", player.displayName)
.replace("%player_name%", player.name)
.replace("%pet%", pet.name)
.replace("%level%", player.getPetLevel(pet).toString())
.formatEco(player)
Expand Down Expand Up @@ -82,13 +83,14 @@ class PetDisplay(
}

private fun getOrNew(player: Player): ArmorStand? {
val tracked = trackedEntities[player.uniqueId]
val existing = tracked?.stand

if (player.isInvisible) {
existing?.remove()
return null
}

val tracked = trackedEntities[player.uniqueId]
val existing = tracked?.stand

val pet = player.activePet
if (pet != tracked?.pet) {
tracked?.stand?.remove()
Expand Down