fix: respect isSimulated config for ContractWrite operations

[chrisli30]

• fix: respect isSimulated config for ContractWrite operations
• refactor: remove redundant nodeValue parameter from runX functions

[Copilot]

Pull Request Overview

This pull request refactors the node execution step creation process to improve type safety and consistency. The main change involves updating createNodeExecutionStep to CreateNodeExecutionStep which now accepts a *avsproto.TaskNode parameter instead of just the NodeType, allowing the function to extract node-specific configuration like is_simulated flags.

Key changes:

• Renamed createNodeExecutionStep to CreateNodeExecutionStep (exported) and changed signature to accept *avsproto.TaskNode
• Added taskNode field to CommonProcessor with getter/setter methods
• Updated all node runner methods (runRestApi, runBalance, runContractRead, etc.) to accept a taskNode parameter
• Modified all processor constructors to properly initialize CommonProcessor with named field vm: vm
• Updated all test cases to create and pass TaskNode wrappers when calling runner methods

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/taskengine/node_utils.go	Refactored createNodeExecutionStep to CreateNodeExecutionStep with new signature accepting TaskNode, improved logic to extract is_simulated from node config
core/taskengine/vm.go	Added taskNode field to CommonProcessor, updated all run* methods to accept taskNode parameter, modified executeNode to pass taskNode to runners
core/taskengine/vm_runner_*.go	Updated all Execute methods to use CreateNodeExecutionStep with taskNode, fixed CommonProcessor initialization in GraphQL processor
core/taskengine/*_test.go	Updated test calls to create TaskNode wrappers and pass to runner methods
core/taskengine/run_node_immediately.go	Updated simulation method call to create TaskNode wrapper
core/taskengine/trigger_data_flattening_test.go	Added missing Type field to TaskNode creation

Comments suppressed due to low confidence (2)

core/taskengine/vm_runner_rest.go:418

• [nitpick] The CommonProcessor is initialized with only the vm field in NewRestProcessor, but not the taskNode field. This is inconsistent with how SetTaskNode is called later in the execution flow. Consider documenting that the taskNode will be set via SetTaskNode() before execution, or initializing it to nil explicitly for clarity.

		CommonProcessor: &CommonProcessor{
			vm: vm,
		},

core/taskengine/vm_runner_rest.go:431

• [nitpick] The CommonProcessor is initialized with only the vm field in NewRestProcessorWithExecutor, but not the taskNode field. This is inconsistent with how SetTaskNode is called later in the execution flow. Consider documenting that the taskNode will be set via SetTaskNode() before execution, or initializing it to nil explicitly for clarity.

		CommonProcessor: &CommonProcessor{
			vm: vm,
		},

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.