Feature/server generalize #2526
Merged
+2,196
−727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
dinhlongviolin1
requested review from
FabienLelaquais and
FredLL-Avaiga
and removed request for
FredLL-Avaiga
Contributor
|
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
github-actions
bot
added
the
🥶Waiting for contributor
github-actions
bot
removed
the
🥶Waiting for contributor
…/taipy into feature/server-generalize
FredLL-Avaiga
approved these changes
Jun 12, 2025
Member
FredLL-Avaiga
left a comment
FredLL-Avaiga
left a comment
There was a problem hiding this comment.
Waow @dinhlongviolin1
Impressive
|
|
||
| def get_flask_app(self) -> Flask: | ||
| """Get the internal Flask application. | ||
| def get_flask_app(self): |
Member
There was a problem hiding this comment.
should we use DeprecationWarning as an exception?
| # Deprecated | ||
| def _set_flask(self, flask): | ||
| raise RuntimeError( | ||
| "'_set_flask()' is deprecated. Use '_set_web_server()' instead as multiple web frameworks has been supported." # noqa: E501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
How to reproduce the issue
Please replace this line with instructions on how to reproduce the issue or test the feature.
Other branches or releases that this needs to be backported
Describe which projects this change will impact and that needs to be backported.
Checklist
We encourage you to keep the code coverage percentage at 80% and above.