Skip to content

process events under authorization. #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025

Conversation

jrobinAV
Copy link
Member

@jrobinAV jrobinAV commented Apr 4, 2025

What type of PR is this? (Check all that apply)

  • πŸ›  Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • ⚑ Optimization
  • πŸ“ Documentation Update

Description

Some bugs and log warnings exist when processing core events in the core_gui context using authorizations.

Related Tickets & Documents

Backporting

This change should be backported to:

  • 3.0
  • 3.1
  • 4.0
  • develop

Checklist

We encourage keeping the code coverage percentage at 80% or above.

  • βœ… This solution meets the acceptance criteria of the related issue.
  • πŸ“ The related issue checklist is completed.
  • πŸ§ͺ This PR includes unit tests for the developed code.
  • πŸ“Œ The release notes have been updated.
    If not, explain why: No need to document a minor log issue

@jrobinAV jrobinAV requested a review from FredLL-Avaiga April 4, 2025 11:56
@jrobinAV jrobinAV added the Enterprise Related to an enterprise feature label Apr 4, 2025
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Apr 4, 2025
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in JR, I trust

@jrobinAV jrobinAV self-assigned this Apr 7, 2025
@jrobinAV jrobinAV added Core Related to Taipy Core πŸ–° GUI Related to GUI Enterprise: πŸ›‚ Authorization Related to Taipy Role management labels Apr 7, 2025
FlorianJacta
FlorianJacta previously approved these changes Apr 8, 2025
Copy link
Member

@FlorianJacta FlorianJacta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrobinAV jrobinAV dismissed stale reviews from FlorianJacta and FredLL-Avaiga via 4ee3519 April 14, 2025 12:04
@jrobinAV jrobinAV marked this pull request as ready for review April 14, 2025 12:13
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Apr 14, 2025
@jrobinAV jrobinAV merged commit 1272995 into develop Apr 14, 2025
125 of 126 checks passed
@jrobinAV jrobinAV deleted the fix/protect-event-processing-in-core-gui-context branch April 14, 2025 13:19
jrobinAV added a commit that referenced this pull request Apr 14, 2025
* process events under authorization.
* Add unit tests
* fix linter

(cherry picked from commit 1272995)
jrobinAV added a commit that referenced this pull request Apr 15, 2025
jrobinAV added a commit that referenced this pull request Apr 15, 2025
* process events under authorization.
* Add unit tests
* fix linter

(cherry picked from commit 1272995)
jrobinAV added a commit that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core Enterprise: πŸ›‚ Authorization Related to Taipy Role management Enterprise Related to an enterprise feature πŸ–° GUI Related to GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants