Skip to content

Simplified build process #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

Conversation

FabienLelaquais
Copy link
Member

Addresses #2514 for 4.1 and forward, and #2515.

  • Compute all dev release index (no more 'dev' in version.json)
  • Bump patch version when creating a production release
  • Favor pyproject.toml over setup and MANIFEST
  • Optimize Taipy build (cache on GUI bundle)
  • Removed unused scripts

TODO: documentation on these.

- Bump patch version when creating a production release
- Favor pyproject.toml over setup and MANIFEST
- Optimize Taipy build (cache on GUI bundle)
- Removed unused scripts
@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🟧 Priority: High Must be addressed as soon labels Apr 9, 2025
@FabienLelaquais FabienLelaquais self-assigned this Apr 9, 2025
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Apr 10, 2025
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json OK
*/setup.py: would it be easier to have a shared function that would take the right arguments and return the content of install_requires
The couple setup.py files I have looked at seems very similar ?

@FabienLelaquais
Copy link
Member Author

json OK */setup.py: would it be easier to have a shared function that would take the right arguments and return the content of install_requires The couple setup.py files I have looked at seems very similar ?

That's a good idea, that is worth trying to tackle in the future.
My worry is that this code would have to be in the most shared package ('taipy.common'), and quite beside the point of the product.
Also, I don't really know if this can work when installing... a dependent pacakge (say 'taipy.core'): the code is needed to install, but because it's in a dependency, it's not there yet.
Any idea?

jrobinAV
jrobinAV previously approved these changes Apr 10, 2025
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah !

@jrobinAV jrobinAV dismissed stale reviews from FredLL-Avaiga and themself via 0ec7ad0 April 10, 2025 12:51
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah !

@FredLL-Avaiga
Copy link
Member

json OK */setup.py: would it be easier to have a shared function that would take the right arguments and return the content of install_requires The couple setup.py files I have looked at seems very similar ?

That's a good idea, that is worth trying to tackle in the future. My worry is that this code would have to be in the most shared package ('taipy.common'), and quite beside the point of the product. Also, I don't really know if this can work when installing... a dependent package (say 'taipy.core'): the code is needed to install, but because it's in a dependency, it's not there yet. Any idea?

You're right, I see 2 solutions to might not be worth the trouble:

  1. manually copy that function in every setup.py file with the right comment
  2. generate the setup.py files before building the packages

@FabienLelaquais FabienLelaquais merged commit 34f3a3b into develop Apr 10, 2025
128 checks passed
@FabienLelaquais FabienLelaquais deleted the devops/#2514-build-process branch April 10, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖧 Devops Operations, monitoring, maintenance, deployment, packaging 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants