Refactor - Allow passing extra package name to check dependency #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stalled() function
There was a problem hiding this comment.
Pull Request Overview
The PR refactors the dependency check mechanism by allowing an extra package name to be passed when verifying installations.
- Updated dependency check calls in Mongo Data Node and S3 Data Node to include an extra package parameter.
- Modified the _check_dependency_is_installed function interface to support the extra package and an optional sublibrary name.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| taipy/core/data/mongo.py | Updated dependency check call with an extra package parameter. |
| taipy/core/data/aws_s3.py | Updated dependency check call with an extra package parameter. |
| taipy/core/common/_check_dependencies.py | Refactored function signature to accept extra package parameters. |
jrobinAV
reviewed
Apr 20, 2025
jrobinAV
previously approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Description
The
_check_dependency_is_installed()function now accept theextra_taipy_package_nameto be extendable.Also, the taipy sub-library name can be provided.