Implement EntryCell VerticalTextAlignment#210
Open
jsuarezruiz wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for EntryCell.VerticalTextAlignment in the Avalonia-based compatibility implementation, ensuring EntryCell text can be top/center/bottom aligned and validated via both unit and render tests.
Changes:
- Implement vertical text alignment mapping for
EntryCellby wiring it into the existing AvaloniaTextBox.VerticalContentAlignmentbehavior. - Adjust
MauiEntryCelllayout so the input can stretch vertically (enabling meaningful vertical content alignment). - Add coverage via new handler tests and a new TableView render test (plus render-test handler registration and project references), and update the ControlGallery sample.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Avalonia.Controls.Maui.Tests/Handlers/Cells/EntryCellHandlerTests.cs | Adds unit tests for initial mapping and runtime updates of VerticalTextAlignment. |
| tests/Avalonia.Controls.Maui.RenderTests/Tests/TableViewRenderTests.cs | Introduces a render test validating visual vertical alignment for EntryCells in a TableView. |
| tests/Avalonia.Controls.Maui.RenderTests/TestAppBuilder.cs | Registers compatibility handlers needed to render TableView/EntryCell in render tests. |
| tests/Avalonia.Controls.Maui.RenderTests/Avalonia.Controls.Maui.RenderTests.csproj | Adds Compatibility project reference so render tests can use compatibility handlers. |
| STATUS.md | Updates implementation status to mark EntryCell.VerticalTextAlignment as implemented. |
| src/Avalonia.Controls.Maui/Extensions/EntryExtensions.cs | Refactors vertical alignment mapping to reuse a new overload taking TextAlignment. |
| src/Avalonia.Controls.Maui/Extensions/EditorExtensions.cs | Reuses the shared vertical alignment mapping helper for editors. |
| src/Avalonia.Controls.Maui.Compatibility/Extensions/EntryCellExtensions.cs | Implements EntryCell vertical alignment mapping via the shared TextBox extension. |
| src/Avalonia.Controls.Maui.Compatibility/Controls/MauiTableView/MauiEntryCell.cs | Changes the input TextBox to stretch vertically to allow top/center/bottom content alignment. |
| samples/ControlGallery/ControlGallery/Pages/TableViewPage.xaml | Adds a sample section demonstrating EntryCell vertical text alignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
EntryCell.VerticalTextAlignmentsupport in the compatibility handler.Changes:
EntryCell.VerticalTextAlignmentthrough the existingEntryCellHandlermapper.EntryCellvertical alignment behavior.