Skip to content

Implement EntryCell VerticalTextAlignment#210

Open
jsuarezruiz wants to merge 1 commit into
mainfrom
entrycell-verticaltextalignment
Open

Implement EntryCell VerticalTextAlignment#210
jsuarezruiz wants to merge 1 commit into
mainfrom
entrycell-verticaltextalignment

Conversation

@jsuarezruiz
Copy link
Copy Markdown
Member

Adds EntryCell.VerticalTextAlignment support in the compatibility handler.

Changes:

  • Maps EntryCell.VerticalTextAlignment through the existing EntryCellHandler mapper.
  • Adds test coverage for initial mapping and property updates. Also, added a render test.
  • Updates the sample to show EntryCell vertical alignment behavior.

Copilot AI review requested due to automatic review settings May 21, 2026 09:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for EntryCell.VerticalTextAlignment in the Avalonia-based compatibility implementation, ensuring EntryCell text can be top/center/bottom aligned and validated via both unit and render tests.

Changes:

  • Implement vertical text alignment mapping for EntryCell by wiring it into the existing Avalonia TextBox.VerticalContentAlignment behavior.
  • Adjust MauiEntryCell layout so the input can stretch vertically (enabling meaningful vertical content alignment).
  • Add coverage via new handler tests and a new TableView render test (plus render-test handler registration and project references), and update the ControlGallery sample.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Avalonia.Controls.Maui.Tests/Handlers/Cells/EntryCellHandlerTests.cs Adds unit tests for initial mapping and runtime updates of VerticalTextAlignment.
tests/Avalonia.Controls.Maui.RenderTests/Tests/TableViewRenderTests.cs Introduces a render test validating visual vertical alignment for EntryCells in a TableView.
tests/Avalonia.Controls.Maui.RenderTests/TestAppBuilder.cs Registers compatibility handlers needed to render TableView/EntryCell in render tests.
tests/Avalonia.Controls.Maui.RenderTests/Avalonia.Controls.Maui.RenderTests.csproj Adds Compatibility project reference so render tests can use compatibility handlers.
STATUS.md Updates implementation status to mark EntryCell.VerticalTextAlignment as implemented.
src/Avalonia.Controls.Maui/Extensions/EntryExtensions.cs Refactors vertical alignment mapping to reuse a new overload taking TextAlignment.
src/Avalonia.Controls.Maui/Extensions/EditorExtensions.cs Reuses the shared vertical alignment mapping helper for editors.
src/Avalonia.Controls.Maui.Compatibility/Extensions/EntryCellExtensions.cs Implements EntryCell vertical alignment mapping via the shared TextBox extension.
src/Avalonia.Controls.Maui.Compatibility/Controls/MauiTableView/MauiEntryCell.cs Changes the input TextBox to stretch vertically to allow top/center/bottom content alignment.
samples/ControlGallery/ControlGallery/Pages/TableViewPage.xaml Adds a sample section demonstrating EntryCell vertical text alignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants