Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Generic.xaml with default TreeDataGrid styles, and make Fluent.axaml inherit it #247

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Jan 3, 2024

Two main benefits:

  1. Any app can now reference Generic.axaml that doesn't depend on any specific theme. Fluent.axaml is still available, and it remaps tree data grid resources to the Fluent resources.
  2. Third party themes like Material, Fluent or Actipro can redefine these resources in their packages without referencing TreeDataGrid and without adding a proxy assembly. Although, style includes order is important here.

In the future we might also want to make Generic.axaml be included automatically by extending Avalonia code.

Fixes #246

@maxkatz6 maxkatz6 requested a review from grokys January 3, 2024 01:49
@maxkatz6 maxkatz6 added the enhancement New feature or request label Jan 3, 2024
@maxkatz6 maxkatz6 merged commit 3e6a6e5 into master Feb 19, 2024
5 checks passed
@maxkatz6 maxkatz6 deleted the introduce-generic-xaml-in-treedatagrid branch February 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeDataGrid does not work unless you are running FluentTheme
1 participant