Handle Move in TreeSelectionMode. #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be a left-over from development. Clear the anchor index if it's invalid to make the test pass.
giard-alexandre
approved these changes
Nov 25, 2024
src/Avalonia.Controls.TreeDataGrid/Selection/SelectionNodeBase.cs
Outdated
Show resolved
Hide resolved
|
Customer has tested and fixes their issue 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
NotifyCollectionChangedAction.Movewould causeTreeSelectionNodeto throw aNotSupportedException. This PR allowsTreeSelectionNodeto handle moves.Note that if the moved item is currently selected, it will be unselected: it does not try to preserve a moved selection as that will require an API change in
TreeSelectionModelIndexesChangedEventArgsto notify of multiple index ranges being changed.