Add ConnectUnixAsync to DBusTransport#11
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds async overloads of ConnectUnix to the DBusTransport class to enable non-blocking Unix domain socket connections for peer-to-peer D-Bus communication with proper cancellation token support.
Changes:
- Adds
ConnectUnixAsync(string socketPath, CancellationToken)overload for basic async connection - Adds
ConnectUnixAsync(string socketPath, IDBusDiagnostics?, CancellationToken)overload with diagnostics support - Implements proper exception handling with socket disposal on connection failure
- Follows the same pattern as the existing synchronous
ConnectUnixmethods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectUnixtoDBusTransportthat usesocket.ConnectAsync()withCancellationTokensupportDBusAutomationclient to allow proper cancellation and retry on connection refusedTest plan
ConnectUnix(sync) tests still passConnectUnixAsyncconnects to a listening Unix socket