-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[WIP] Distribute LineGap evenly to top and bottom #19556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You can test this PR using the following package version. |
I'm sorry to be that guy again, but please add a test so we can validate the calculated behavior and we won't regress it in the future. |
|
We need to find a font file that defines |
We can create some or edit the current test fonts as needed |
You can test this PR using the following package version. |
What does the pull request do?
The PR adjusts the baseline calculation so that a defined line gap is distributed evenly to the top and bottom of the text line
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes: #19547