Don't self-register FontManager #19600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simplified this PR a lot by using AvaloniaLocator.ToLazy method. Also reverting initialization order changes. Now this PR shouldn't introduce any potential behavioral changes. |
|
Note: a lot of tests are failing. |
|
Weirdly, failing tests are platform specific. And none are failing on my machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Instead of self-registering FontManager on first access, it's safer to keep lazy initialization inside of AvaloniaLocator.
At first, I implemented this PR by registering FontManager early, during rendering backend initialization. But then I remembered about AvaloniaLocator.ToLazy being an option and redid this PR.
Fixed issues
Fixes #10081