Skip to content

Conversation

@MrJul
Copy link
Member

@MrJul MrJul commented Dec 19, 2025

What does the pull request do?

This PR splits the Analyzers project into three:

  • Analyzers.CSharp
  • Analyzers.VisualBasic
  • Analyzers.CodeFixes.CSharp

Types for code fixes or other languages aren't guaranteed to be referenced while compiling outside IDEs. We didn't have any trouble before because we aren't blindly using those, but let's be explicit.

This follows the recommendation from Microsoft, see RS1038 for details.

@MrJul MrJul changed the title Split analyzers and codefixes into separate projects Split analyzers and code fixes into separate projects Dec 19, 2025
@MrJul MrJul force-pushed the fix/split-analyzers-codefixes branch from d115efa to 2355de8 Compare December 19, 2025 15:18
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0060939-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul mentioned this pull request Jan 5, 2026
3 tasks
@maxkatz6
Copy link
Member

maxkatz6 commented Jan 7, 2026

It's just different assemblies, still kept in the single nuget package, right?
Feels excessive, and I don't remember if I saw many projects do that. But since Microsoft recommends it, I am good.

@MrJul
Copy link
Member Author

MrJul commented Jan 7, 2026

It's just different assemblies, still kept in the single nuget package, right?

Yes, they're all merged into our main Avalonia package at build time.

Feels excessive, and I don't remember if I saw many projects do that. But since Microsoft recommends it, I am good.

It's a fairly recent public recommendation from the analyzers afaict, but Microsoft has been using it for a while:

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0061273-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into AvaloniaUI:master with commit 4b07100 Jan 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants