-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix ambiguous and dead inheritdoc links
#20397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…object?,DispatcherPriority) for clarity
Documentation sourced from 0e2cee8
|
While working on this PR, I think I found a bug - If I am correct, do I have permission to add it to this PR? Or would a separate PR be preferred? |
|
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
|
@ScrubN brush invalidation was removed from other brush types, and it seems to still be used here. Better to add simple xml doc specifically on this implementation, without changing any interfaces. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
Note: some fixes here actually introduced actual compiler warnings, see #20429. |
Oh, I'm sorry! I didn't have the free space to fetch the missing workloads to test compile and ReSharper solution analysis didn't catch it. |
|
No worries (we'll hopefully be enabling warnings as errors soon on CI). |
What does the pull request do?
Explicitly defines documentation in places where it is from an ambiguous base class/interface or where it is no longer valid due to inheritance changes.
What is the current behavior?
Certain methods, such as
Dispatcher.Post(Action, DispatcherPriority), fail to resolve documentation with Rider/ReSharper.Other methods, such as
ExperimentalAcrylicMaterial.Invalidated, have deadinheritdoclinks.What is the updated/expected behavior with this PR?
Rider/ReSharper successfully resolves the documentation of the affected methods.
Checklist