Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a mode where drawn decorations are forced by the platform backend regardless of the extend-client-area-to-decorations hint from the user code.
Note that the implementation contains a hack required to prevent invalid window dimensions when restoring from maximized/fullscreen mode - ArrangeSetBounds is moved to TopLevelHost in that case.
The hack is needed for the following scenario:
The hack moves PlatformImpl.Resize to TopLevelHost and it is skipped on arrange if size is unchanged. Since Window's own measure is somehow still valid at this point (no resize event happened, I suppose) it somehow still works. I've tried moving this check to Window, but layout cycle would mess up the sizing.
The hack is disabled for existing platforms since they don't have forced decorations mode yet.
@MrJul I don't think we should be merging this for RC1, right now the PR is here for me to base wayland branch on (it needs this mode).