Skip to content

Fix RTL run handling in text run cache - #21292

Closed
kerams wants to merge 1 commit into
AvaloniaUI:masterfrom
kerams:rtl
Closed

Fix RTL run handling in text run cache#21292
kerams wants to merge 1 commit into
AvaloniaUI:masterfrom
kerams:rtl

Conversation

@kerams

@kerams kerams commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

What does the pull request do?

Fixes #21232.

What is the current behavior?

See the issue.

What is the updated/expected behavior with this PR?

See the issue.

How was the solution implemented (if it's not obvious)?

For RTL runs a buffer copy is created, because in-place Bidi reordering causes double reversal.

Checklist

@Gillibald

Gillibald commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

I have a proper fix to this issue that hasn't been published yet.

master...Gillibald:Avalonia:fixes/doubleReorder

@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0065172-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald

Copy link
Copy Markdown
Contributor

Superseeded by: #21351

Thank you for your contribution. The linked PR fixes #21232 and improves overall performance by avoiding the double reversal of the shaped buffer.

@Gillibald Gillibald closed this May 12, 2026
@kerams
kerams deleted the rtl branch May 12, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL text rendered incorrectly

4 participants