fix(SelectableTextBlock): fix SelectableTextBlock selection for centered and right-aligned text#21369
Open
zrt2399 wants to merge 2 commits into
Open
fix(SelectableTextBlock): fix SelectableTextBlock selection for centered and right-aligned text#21369zrt2399 wants to merge 2 commits into
zrt2399 wants to merge 2 commits into
Conversation
…red and right-aligned text
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #21368
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
SelectableTextBlock was unable to select the full text content when TextAlignment was set to Center or Right.
The issue was caused by pointer hit-testing during drag selection clamping the X coordinate to TextLayout.WidthIncludingTrailingWhitespace. For centered and right-aligned text, the rendered text can start later within the available layout width, so clamping to the text width prevented the selection logic from reaching the trailing characters.
This change updates the drag-selection hit-testing logic to clamp against the available layout width when appropriate, allowing selection to extend to the visual end of the text for non-left-aligned content.
Also added regression tests covering drag selection with Center and Right text alignment, and normalized the sample XAML self-closing tag formatting to keep build validation clean.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
fix #21368