[Text] Glyph Outline Part 5/13 - Shaped buffer glyph indices - #21501
Open
Gillibald wants to merge 10 commits into
Open
[Text] Glyph Outline Part 5/13 - Shaped buffer glyph indices#21501Gillibald wants to merge 10 commits into
Gillibald wants to merge 10 commits into
Conversation
Gillibald
added
enhancement
area-textprocessing
api-needs-review
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
2 times, most recently
from
June 5, 2026 05:06
68671b9 to
5a96610
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
June 5, 2026 08:50
5a96610 to
35594bc
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
2 times, most recently
from
June 8, 2026 04:59
4ec6206 to
0d5b7a1
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
June 8, 2026 09:02
0d5b7a1 to
c4f34c2
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
June 12, 2026 13:37
c4f34c2 to
580365f
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
2 times, most recently
from
June 12, 2026 16:12
ec2b9b8 to
091ab0d
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
June 23, 2026 09:47
091ab0d to
75d4b75
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
2 times, most recently
from
August 20, 2026 05:06
2b80803 to
5b624da
Compare
MrJul
added
api-approved
Member
|
Notes from the API review meeting: |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
August 20, 2026 10:10
5b624da to
dcfd6f4
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
August 24, 2026 10:46
dcfd6f4 to
22b1747
Compare
|
You can test this PR using the following package version. |
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
August 28, 2026 07:00
22b1747 to
779d97c
Compare
miloush
previously approved these changes
Aug 28, 2026
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
August 31, 2026 07:51
779d97c to
6899fb6
Compare
|
You can test this PR using the following package version. |
miloush
reviewed
Sep 4, 2026
miloush
reviewed
Sep 4, 2026
miloush
previously approved these changes
Sep 4, 2026
GlyphMetrics previously stored the advance in Width/Height, leaving no field for the actual ink bounding box. Correct the contract: - Expand GlyphMetrics with AdvanceWidth / AdvanceHeight (and the bitmap / vertical-layout members XOffset / YOffset / VerticalOriginX/Y, reserved for later population). - Add GlyfTable.TryGetGlyphBounds: an allocation-free, header-only read of the glyph's control-point bounding box (xMin/yMin/xMax/yMax). Empty glyphs return true with zero bounds; out-of-range / short data return false. Composite glyphs use their header bbox without recursion. - TryGetGlyphMetrics (single + batch) now sources advances into AdvanceWidth / AdvanceHeight and the bounding box into Width / Height / XBearing / YBearing via TryGetGlyphBounds. Side bearings fall back to hmtx/vmtx when the glyph has no outline. The previously latent API had one test relying on the old behaviour (Width == advance); it's updated to assert AdvanceWidth. New tests cover TryGetGlyphBounds (range, empty, letter, descriptor parity) and the corrected metrics (advance placement, ink width distinct from advance, empty-glyph advance-without-ink, batch/single parity).
GlyphBoundsBenchmark (Avalonia.Benchmarks): a BenchmarkDotNet comparison of the table-based bounds read against Skia's SKFont.GetGlyphWidths, in kernel (font pre-created) and per-run variants across 1 / 16 / 256 glyphs, with MemoryDiagnoser.
Adds a bounds-only batch reader so ink-bounds computation (the GlyphRunImpl use case, which already has advances from shaping) doesn't pay for advance lookup or per-glyph indirection: - GlyphBounds: internal value type carrying the control-point box. - GlyfTable.GetGlyphBounds / GlyphTypeface.TryGetGlyphBounds: fetch the glyf and loca spans once per batch and read offsets + headers directly via BinaryPrimitives — no per-glyph ReadOnlyMemory.Span conversion, no intermediate Memory.Slice, no nested call chain. LocaTable exposes RawData / IsShortFormat for this. - Batch TryGetGlyphMetrics refactored onto the same span-cached reader. Measured against Skia's SKFont.GetGlyphWidths (bounds-only, in-process BenchmarkDotNet): the table path is faster at every run length (0.06× / 0.32× / 0.66× at 1 / 16 / 256 glyphs) and allocation-free, where Skia allocates 104 B/run for the SKFont. The earlier advance+bounds path via TryGetGlyphMetrics was ~2.2× slower than Skia at 256 glyphs; the bounds-only span-cached path is ~1.5× faster. The benchmark is updated to compare bounds-only on both sides.
The glyf bounds readers (TryGetGlyphBounds / GetGlyphBounds) read the header int16s via BinaryPrimitives. The base pr2 commit trimmed this using as unused there, but it is needed once pr2b adds the bounds code — without it GlyfTable does not compile on this branch.
GlyphBounds.Width/Height and both TryGetGlyphMetrics overloads computed the ink extent as (xMax - xMin) / (yMax - yMin). A malformed glyf header where xMax < xMin (or yMax < yMin) produced a negative value that, when narrowed to the ushort GlyphMetrics.Width/Height, wrapped to a huge positive extent instead of a safe zero. Clamp the extent to non-negative in GlyphBounds (the single source of truth for both the single and batch metric paths) and route the single TryGetGlyphMetrics path through GlyphBounds so both behave identically. For int16 coordinates the maximum extent is 65535 = ushort.MaxValue, so the clamped value always fits without overflow. Adds GlyphBoundsTests.
Batch TryGetGlyphMetrics unconditionally sized the hMetrics, vMetrics and bounds temporary buffers to glyphIds.Length, even when the font has no hmtx, no vmtx, or no glyf table. For CFF/CFF2 fonts (no glyf) the bounds buffer is never read, and most fonts have no vmtx, so a large batch on such a font heap-allocated a per-glyph array that was pure waste. Size each buffer to zero — a free, empty stackalloc — when its source table is absent, so it only materialises (and only spills to the heap past 256 glyphs) when it will actually be filled and read.
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
2 times, most recently
from
September 7, 2026 07:07
cf5c0ca to
d28eee4
Compare
The short loca format stores every offset divided by two, which is why the batch reader doubles what it reads. LocaTable's single-glyph path already carries that note; the inline decode in the batch path did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The glyf check does not vary across the run, so it belongs above the loop rather than inside it. Splitting it also lets the bounds buffer live only in the branch that reads it, which drops the zero-length allocation that CFF / CFF2 fonts used to make just to satisfy the shared loop. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mirror the existing TryGetHorizontalGlyphAdvance / ...Advances pair with vertical equivalents. Until now a vertical-layout caller (CJK, Mongolian) had no advance-only path on GlyphTypeface and had to go through TryGetGlyphMetrics, which after PR2b reads the glyf bounding box per glyph — pure waste when only the advance is needed. VerticalMetricsTable already exposes the per-glyph and batch readers internally (used by TryGetGlyphMetrics(batch)); this is a thin wrapper over them. Tests cover the Latin (no vmtx → false) and CJK (vmtx → positive advances) cases and batch/single parity using Inter and MiSans-Normal. Audit note: HorizontalMetricsTable and VerticalMetricsTable batch readers already span-cache (each fetches _data.Span once per call, reusing a BigEndianBinaryReader across glyphs). No metrics-table refactor is needed — the speculative Part 2 of the plan collapses to nothing.
Consumers that need a ReadOnlySpan<ushort> of glyph IDs (the upcoming GlyphTypeface.TryGetGlyphBounds batch path, SKFont.GetGlyphWidths, atlas lookups...) previously had to allocate a parallel ushort[] and project GlyphInfo.GlyphIndex into it. Carry that array on the ShapedBuffer instead: - ShapedBuffer rents a parallel ushort[] from ArrayPool alongside the existing GlyphInfo[] rental, exposed as `public ReadOnlySpan<ushort> GlyphIndices`. - The indexer setter syncs both, so HarfBuzz shaping and post-shape mutators (InterWordJustification rewrites the same GlyphIndex) keep the parallel view in lockstep with no caller change. - Split / WithBidiLevel slice the indices alongside the GlyphInfos at the same offsets — both share the parent's pooled arrays. - Dispose returns both rentals. Consumer wiring: - GlyphRunImpl: copies ShapedBuffer.GlyphIndices once via CopyTo when the source is a ShapedBuffer, dropping the per-glyph extract from the position loop. - TextFormatterImpl.CreateEmptyTextLine: switched to the pooled public ctor + indexer (was passing a heap-allocated GlyphInfo[] to the internal slice ctor, which now requires a parallel ushort slice). Tests cover indexer sync, overwrite, ascending split alignment, empty-leading split, and dispose clearing the view.
Gillibald
force-pushed
the
pr2d/shaped-buffer-glyph-indices
branch
from
September 7, 2026 07:30
d28eee4 to
129a672
Compare
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 7, 2026
MrJul
enabled auto-merge
September 7, 2026 10:44
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 15 of the glyph-outline / variable-font workstream. Stacked on Part 4 (
pr2e/metrics-batch-cleanup);What does the pull request do?
Exposes the post-shaping glyph indices of a run as one contiguous span:
GlyphRunImpland the batch readers added in Part 3 all want the same shape, every glyph index in this run as a single span. Extracting that from the existingReadOnlyMemory<GlyphInfo>costs either a copy or a per-glyph field read, on the hot text path.What is the updated/expected behavior with this PR?
ShapedBufferkeeps a parallelushort[]of glyph indices alongside the existingGlyphInfoarray, filled by the same loop that builds it, so the cost is one extra store per glyph rather than a second pass.GlyphRunImplreads that span when callingTryGetHorizontalGlyphAdvancesand the bounds reader, replacing a materialisation it was doing per call.GlyphInfolayout and existingGlyphInfo[i].GlyphIndexaccess are all unchanged. Callers that do not want the span pay nothing for it.The backing field is settable only from the shaping path; the public surface is the read-only span.
Checklist
Breaking changes
None. The property is additive.
Obsoletions / Deprecations
None.
Fixed issues
None.