feat(macos): add traffic light position customization - #22128
Open
Illustar0 wants to merge 2 commits into
Open
Conversation
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds support for customizing macOS traffic light button positions through
MacOSProperties.TrafficLightPosition, including XAML usage.API
Usage
What is the current behavior?
The macOS traffic light buttons always use the system-provided position. Applications extending content into the title bar cannot align them with a custom title bar layout.
What is the updated/expected behavior with this PR?
Applications can specify the top-leading traffic light position in logical units. Setting the property to
nullrestores the system layout.How was the solution implemented (if it's not obvious)?
The native implementation keeps explicit System and Custom layout states. It preserves AppKit’s button sizes, spacing, RTL ordering, and tracking areas, while restoring system-owned layout for fullscreen and unsupported decoration modes.
Custom positioning is reapplied after AppKit title-bar layout changes, including initial display, resizing, appearance changes, and window-state transitions.
Electron and Zed implementations were researched to account for relevant AppKit behavior and known edge cases.
Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #21119