Skip to content

Fix X11 AVALONIA_SCREEN_SCALE_FACTORS handling - #22129

Merged
MrJul merged 1 commit into
AvaloniaUI:mainfrom
dotnet-campus:t/lindexi/AvaloniaX11ScreenScale
Sep 2, 2026
Merged

Fix X11 AVALONIA_SCREEN_SCALE_FACTORS handling#22129
MrJul merged 1 commit into
AvaloniaUI:mainfrom
dotnet-campus:t/lindexi/AvaloniaX11ScreenScale

Conversation

@lindexi

@lindexi lindexi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

Since the index is 0-based, the original condition was incorrect — it shouldn't check > 0, it should be >= 0.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues


Author By: @kkwpsv

And I'm the porter (LOL )

@MrJul MrJul added bug area-x11 backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Sep 2, 2026
@MrJul MrJul changed the title Fix the avalonia scale in x11 Fix X11 AVALONIA_SCREEN_SCALE_FACTORS handling Sep 2, 2026
@MrJul

MrJul commented Sep 2, 2026

Copy link
Copy Markdown
Member

I've renamed the PR: it only affects people who use the AVALONIA_SCREEN_SCALE_FACTORS environment variable.

@MrJul MrJul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrJul
MrJul enabled auto-merge September 2, 2026 08:51
@MrJul
MrJul added this pull request to the merge queue Sep 2, 2026
@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.2.999-cibuild0069338-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@lindexi

lindexi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @MrJul

Merged via the queue into AvaloniaUI:main with commit 4ace5b7 Sep 2, 2026
10 checks passed
@lindexi
lindexi deleted the t/lindexi/AvaloniaX11ScreenScale branch September 2, 2026 11:11
MrJul pushed a commit to MrJul/Avalonia that referenced this pull request Sep 2, 2026
@MrJul MrJul added backported-12.1.x and removed backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants