Unify shutdown handling and subscribe UI dispatcher event - #22155
Open
RyouDYFZ wants to merge 1 commit into
Open
Unify shutdown handling and subscribe UI dispatcher event#22155RyouDYFZ wants to merge 1 commit into
RyouDYFZ wants to merge 1 commit into
Conversation
Replace the previous ProcessExit-only handler with a unified OnShutdown handler in AvaloniaNativePlatform. The code now subscribes to Dispatcher.UIThread.ShutdownFinished as well as AppDomain.CurrentDomain.ProcessExit, and the handler unsubscribes from both before disposing the native factory.
|
You can test this PR using the following package version. |
Collaborator
|
Author
|
@cla-avalonia agree |
maxkatz6
added
bug
os-macos
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Releases Avalonia Native resources when the UI dispatcher finishes shutting down, addressing the late release of managed callbacks reported in #22062
What is the current behavior?
Native factory cleanup relies exclusively on
AppDomain.ProcessExit. Managed callbacks can remain referenced by native static storage until runtime teardown, causing the reported macOS shutdown crash on .NET 11.What is the updated/expected behavior with this PR?
The native factory is disposed before the desktop application’s main loop returns. ProcessExit remains a fallback when dispatcher shutdown does not occur.
Checklist
Fixed issues
Fixes #22062