Add TableViewColumn.IsVisible property - #22162
Open
OleRoss wants to merge 5 commits into
Open
Conversation
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Since I would really like to see the TableViewColumn have an
IsVisibleproperty, I thought I'd go ahead and prepare a small PR for it.What is the current behavior?
There is no IsVisible property on a TableViewColumn, so when columns are defined in axaml, you must set the width either in code-behind or using a custom converter.
What is the updated/expected behavior with this PR?
TableViewColumn now has an IsVisible property, matching the existing DataGrid/TreeDataGrid solutions for dotnet and user expectations.
How was the solution implemented (if it's not obvious)?
Some considerations I had regarding performance: I was not sure if it makes sense to call
RefreshHeader/RefreshCellon an ' IsVisible change. Those methods seem to pull the latest value for all the column's properties and update bindings, which isn't really necessary when only updating IsVisible. But I kept it simple and didn't introduce a separate refresh path in this PR.Note: Some tests were implemented by AI and include edge cases found by the reviewer.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Closes #21818.