Syntax highlight using ReadOnlyMemory<char> for reduced allocations #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udlose
reviewed
Dec 17, 2025
| <IncludeSymbols>true</IncludeSymbols> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
|
|
||
| <Version>11.3.0</Version> |
Contributor
There was a problem hiding this comment.
Minimal required version
There was a problem hiding this comment.
Minimal required version
@Gillibald
Isn't that property the main version number for AvaloniaEdit? Don't you bump the version number when you release a new version? Or is this not the version number for the AvaloniaEdit nuget package?
Contributor
There was a problem hiding this comment.
This is not a release branch, so the version should not be adjusted. If a release is prepared, this needs to be adjusted.
There was a problem hiding this comment.
Ok thanks. Will a release be coming? I'm still waiting to get a fix for a bug that was fixed back in May. Much appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades TextMateSharp from
v1.0.xtov2.0.2and addsReadOnlyMemory<char>APIs to reduce string allocations during syntax highlighting.Benchmark Results
See danipen/TextMateSharp#100
Tested with a 133,439 line C# file (5.8 MB):