fix: add clarifying note for device machine identifiers#203
Open
Jack-sh1 wants to merge 1 commit intoAvdLee:mainfrom
Open
fix: add clarifying note for device machine identifiers#203Jack-sh1 wants to merge 1 commit intoAvdLee:mainfrom
Jack-sh1 wants to merge 1 commit intoAvdLee:mainfrom
Conversation
Resolves AvdLee#107 The machine ID (e.g. "iPhone14,5") can be confused with iOS version numbers. This adds a note to clarify it is a hardware identifier, and expands the device name mapping through iPhone 16 series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #107.
The device machine identifier (e.g.
iPhone14,5) can easily be confusedwith iOS version numbers. This PR:
(e.g. "iPhone 13 (Machine ID: iPhone14,5)")
unmapped hardware identifiers
hardwareNamedictionary with models through iPhone 16 series