-
-
Notifications
You must be signed in to change notification settings - Fork 18
ci: cleanup dockerfiles #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up and optimizes the Docker configuration for the project by modernizing the Dockerfile, simplifying the Docker Compose setup, and removing unnecessary dependencies.
- Updated WordPress base image version and simplified container setup
- Added health checks and container names to Docker Compose services
- Removed XDebug and Dockerize dependencies to reduce image complexity
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updated WordPress compatibility version to 6.8.2 |
| docker-compose.yml | Added container names, health checks, and corrected build context |
| .github/workflows/codeception.yml | Removed XDebug-related environment variables |
| .docker/init-docker.sh | Removed database wait logic and dockerize dependency |
| .docker/Dockerfile | Simplified image by removing XDebug, dockerize, and unnecessary packages |
Comments suppressed due to low confidence (1)
.docker/Dockerfile:10
- WordPress 6.8 may not exist yet. The latest stable WordPress version as of my knowledge cutoff was 6.6. Consider verifying that WordPress 6.8 is available or use a known stable version like 6.6.
FROM wordpress:${WP_VERSION:-6.8}-php${PHP_VERSION:-8.2}-apache AS base
What
Why
How
Testing Instructions
Additional Info
Checklist: