-
-
Notifications
You must be signed in to change notification settings - Fork 18
release: v0.4.4 #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.4.4 #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Security patch release preventing masked JWT secret value from overwriting the real secret and routine version/dependency bumps.
- Adds masking constant and attempt to sanitize inbound secret updates.
- Introduces test to ensure masked secret cannot overwrite stored secret.
- Version, dependency, and documentation updates for release 0.4.4.
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| wp-graphql-headless-login.php | Version and compatibility metadata bumped. |
| src/Admin/Settings/RestController.php | Adds masking constant and sanitization logic; restructures route registration. |
| src/Model/Client.php | Refactors docblock, removes explicit $data property annotation, adds phpstan generics. |
| src/Auth/Request.php | Minor formatting cleanup. |
| tests/wpunit/SettingsRestControllerTest.php | Adds test ensuring masked secret values do not overwrite actual secret. |
| composer.json | Updates wp-cli dependency. |
| readme.txt | Updates stable tag and tested WP version. |
| README.md | Updates release badge to 0.4.4. |
| CHANGELOG.md | Adds 0.4.4 release notes. |
| phpstan/constants.php | Syncs version constant for static analysis. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5978292 to
f53dbc3
Compare
|
I'll fix CI later. |
What
This PR updates the REST_Controller to prevent a malicious authenticated user from setting the
jwt_secret_keyto********and therefore hiding the fact that the JWT's been compromised.Why
Identified by Rapid7 and reported responsibly and with a fix + test case by @M-GRV . Thank you!🏆
How
See diff
Testing Instructions
manage_optionsPOSTto the settings endpoint with********Additional Info
Checklist: