refactor: standardise API client layer - #344
Merged
El-swaggerito merged 1 commit intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333
Summary
This PR standardises the dashboard API client layer by unifying scattered direct
fetchcalls under the robustEnhancedApiClientlocated insrc/utils/enhancedApiClient.ts.Current Behaviour
API calls were scattered across components, services, and utility files (e.g.,
WalletContext,protocolHealth,sorobanRpcFetcher), relying on rawfetchcalls with inconsistent error handling and retry logic.Expected Behaviour
The dashboard now uses a central API client layer providing:
AppErrortypes).NETWORK,TIMEOUT,SERVER).Key Changes
src/contexts/WalletContext.tsxsrc/services/events/sorobanRpcFetcher.tssrc/services/protocolHealth.tssrc/utils/telemetry.tsEnhancedApiClientEmpty Body Bug: Handled204 No Content/ empty responses safely by skipping JSON parsing when appropriate to prevent unnecessaryjson()parse errors (e.g., during telemetry tracking).src/utils/apiClient.tsas its core functions (sorobanRpcfetching) are now natively supported viaapiPost.docs/API_CLIENT.mdto document the convention of usingEnhancedApiClient(apiGet,apiPost), including its error categorisation and retry policies.Let me know if there's anything else you need!