refactor(network): add network client for standardized requests - #158
Merged
Conversation
Replace manual fetchWithTimeout usage in fundTestnetAccount with the new NetworkClient. Update error handling to map generic HTTP errors to Friendbot-specific error codes. Add executeHorizonOperation and executeSorobanOperation helpers for consistent operation wrapping.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a typed network client abstraction for Horizon and future Soroban RPC usage, ensuring consistent timeout handling, response parsing, and SDK error conversion for all network operations.
Changes
NetworkClientclass (src/network/index.ts#L81-L187): Typed HTTP client withgetandpostmethods, built on top of existingfetchWithTimeoutwith consistent error handling and JSON parsingexecuteHorizonOperationhelper (src/network/index.ts#L192-L213): Wraps Horizon server operations with timeout and consistent error handlingexecuteSorobanOperationhelper (src/network/index.ts#L218-L231): Wraps Soroban RPC operations with timeout and consistent error handlingfundTestnetAccount(src/wallet/index.ts#L198-L254): Refactored to useNetworkClientinstead of directfetchWithTimeoutcallsWhy
Testing
npm run test)npm run build)Closes #157